-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to TypeScript + 0.10.0 Gamemode Changes #146
Port to TypeScript + 0.10.0 Gamemode Changes #146
Commits on Aug 28, 2024
-
chore: remove stubbed tricksurf UI
Not doing for ages, don't any reason to keep the stubbed stuff around.
Configuration menu - View commit details
-
Copy full SHA for afaad6d - Browse repository at this point
Copy the full SHA afaad6dView commit details -
chore: upgrade all dependencies
Not pinning dev dependencies. It's not a big deal, and we're not in prod.
Configuration menu - View commit details
-
Copy full SHA for 2b44695 - Browse repository at this point
Copy the full SHA 2b44695View commit details -
Configuration menu - View commit details
-
Copy full SHA for dac4ac9 - Browse repository at this point
Copy the full SHA dac4ac9View commit details -
chore: disable bad eslint rules
"class-methods-use-this" is just annoying, not much benefit to static methods in JS, and doesn't work well with our PanelHandler system
Configuration menu - View commit details
-
Copy full SHA for 8bc13fb - Browse repository at this point
Copy the full SHA 8bc13fbView commit details -
chore: migrate ESLint to flat config
Idk, eslint updated and their config changed. Fun!
Configuration menu - View commit details
-
Copy full SHA for b4879b6 - Browse repository at this point
Copy the full SHA b4879b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d264046 - Browse repository at this point
Copy the full SHA d264046View commit details -
Configuration menu - View commit details
-
Copy full SHA for caa20eb - Browse repository at this point
Copy the full SHA caa20ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b745d3 - Browse repository at this point
Copy the full SHA 6b745d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for eba5e6e - Browse repository at this point
Copy the full SHA eba5e6eView commit details -
chore: disable typescript strict null checks
This causing people headaches, and not super beneficial.
Configuration menu - View commit details
-
Copy full SHA for 22189c5 - Browse repository at this point
Copy the full SHA 22189c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c84abf - Browse repository at this point
Copy the full SHA 0c84abfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bdbc60 - Browse repository at this point
Copy the full SHA 2bdbc60View commit details -
chore: enable TS source mapping
Kiiiiind of works with debugger! And assume we'll want this once SCell's thing is in.
Configuration menu - View commit details
-
Copy full SHA for 8fb7d94 - Browse repository at this point
Copy the full SHA 8fb7d94View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd30881 - Browse repository at this point
Copy the full SHA fd30881View commit details -
Configuration menu - View commit details
-
Copy full SHA for c90f5ab - Browse repository at this point
Copy the full SHA c90f5abView commit details
Commits on Sep 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4615ea4 - Browse repository at this point
Copy the full SHA 4615ea4View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb48143 - Browse repository at this point
Copy the full SHA bb48143View commit details -
chore: rename every .js file to .ts
There absolutely no code changes here, just moves, to keep files linked in Git and so review is easier.
Configuration menu - View commit details
-
Copy full SHA for 79d6e1f - Browse repository at this point
Copy the full SHA 79d6e1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7eb506d - Browse repository at this point
Copy the full SHA 7eb506dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bf6897 - Browse repository at this point
Copy the full SHA 6bf6897View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a9f6f0 - Browse repository at this point
Copy the full SHA 4a9f6f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c0d633 - Browse repository at this point
Copy the full SHA 4c0d633View commit details -
refactor: remove levels-explainer popup JS, replace with inline script
Don't like having a dedicated script for something simple as this, better in <script> tag.
Configuration menu - View commit details
-
Copy full SHA for ddef224 - Browse repository at this point
Copy the full SHA ddef224View commit details -
feat: @PanelHandler decorator and other module helper functions
I know this feels a bit framework-y but with modules it's really needed, otherwise exposing stuff to XML takes a lot of boilerplate.
Configuration menu - View commit details
-
Copy full SHA for fde5c5f - Browse repository at this point
Copy the full SHA fde5c5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c780cd3 - Browse repository at this point
Copy the full SHA c780cd3View commit details -
refactor: convert everything to TypeScript
Chungus commit but not that much to break up. Tried to not refactor too much but I tweaked some things as I went. Couple of general comments: - Suffixing every class with "Handler" is very verbose but omitting it will be a namespace collision for JS-defined panels like LevelIndicator, so figured I'd keep consistent and suffix everything. - static is no longer required everywhere because of @PanelHandler instantiating classes it's applied to. Maybe a bit too magical, but I like not having static on absolutely everything. - We should avoid .bind(this) with event handlers, it's easy to introduce type errors when using it, since it provides no type-safety between the event handler function signature and the function it's applied to. Arrow functions do the same thing, and make the arguments explicit.
Configuration menu - View commit details
-
Copy full SHA for cae7386 - Browse repository at this point
Copy the full SHA cae7386View commit details -
refactor: convert speedometers to TypeScript
This stuff is all interconnected so figured I'd split them out from main ts port commit Refactored a bit of gamemode handling logic as well, needed a C++ fix to get config loading working with new modes, that's in review on red.
Configuration menu - View commit details
-
Copy full SHA for 3344b4a - Browse repository at this point
Copy the full SHA 3344b4aView commit details -
refactor: remove/rename stupid main menu events
Show/HideContentPanel weren't doing anything. ReloadBackground is ambigious. Guhh!!!
Configuration menu - View commit details
-
Copy full SHA for f147083 - Browse repository at this point
Copy the full SHA f147083View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4ac14f - Browse repository at this point
Copy the full SHA f4ac14fView commit details -
refactor: make toasts look a bit less terrible
Not doing much styling in this PR, just couldn't resist improving these slightly.
Configuration menu - View commit details
-
Copy full SHA for bbff206 - Browse repository at this point
Copy the full SHA bbff206View commit details -
Configuration menu - View commit details
-
Copy full SHA for b718dc8 - Browse repository at this point
Copy the full SHA b718dc8View commit details -
refactor: comment out "View Showcase Run" button in tab-menu
This thing just confuses people, had multiple people ask why it doesn't work. Doesn't look very good in its current state, may as well just hide for now.
Configuration menu - View commit details
-
Copy full SHA for 6e3d6d6 - Browse repository at this point
Copy the full SHA 6e3d6d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for b578792 - Browse repository at this point
Copy the full SHA b578792View commit details -
Configuration menu - View commit details
-
Copy full SHA for d50760e - Browse repository at this point
Copy the full SHA d50760eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 84f14c9 - Browse repository at this point
Copy the full SHA 84f14c9View commit details -
Toop was having issues with default line endings in vscode, this should set right defaults
Configuration menu - View commit details
-
Copy full SHA for 8d3a057 - Browse repository at this point
Copy the full SHA 8d3a057View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40fdd64 - Browse repository at this point
Copy the full SHA 40fdd64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 010d70c - Browse repository at this point
Copy the full SHA 010d70cView commit details