Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vector stuff #149

Merged
merged 2 commits into from
Sep 13, 2024
Merged

vector stuff #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abeb43c
chore: upgrade dependencies
PeenScreeker Sep 9, 2024
ebd5a87
feat: make vector functions more flexible
PeenScreeker Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 3 additions & 11 deletions scripts/util/math.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,26 +2,18 @@ export function magnitude(vec: vec2 | vec3): number {
return Math.sqrt(sumOfSquares(vec));
}

export function magnitude2D(vec: vec2): number {
export function magnitude2D(vec: vec2 | vec3): number {
return Math.sqrt(sumOfSquares2D(vec));
}

export function magnitude3D(vec: vec3): number {
return Math.sqrt(sumOfSquares3D(vec));
}

// Note: Math.hypot performs additional bounds checking on V8 which which makes it considerably
// slower than below implementations.
export function sumOfSquares2D(vec: vec2): number {
export function sumOfSquares2D(vec: vec2 | vec3): number {
return vec.x ** 2 + vec.y ** 2;
}

export function sumOfSquares3D(vec: vec3): number {
return vec.x ** 2 + vec.y ** 2 + vec.z ** 2;
}

export function sumOfSquares(vec: vec2 | vec3): number {
return 'z' in vec ? vec.x ** 2 + vec.y ** 2 + vec.z ** 2 : vec.x ** 2 + vec.y ** 2;
return 'z' in vec ? vec.x ** 2 + vec.y ** 2 + vec.z ** 2 : sumOfSquares2D(vec);
}

/**
Expand Down
Loading