Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teleport to region in zoning UI #151

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Conversation

PeenScreeker
Copy link
Member

This pull request implements teleport functionality to the zoning UI. By double clicking a zone in the tracklist, the player can teleport to the first region of the selected zone.

This functionality could be improved to select the particular region of multi-region volumes.

Depends on red changes (teleport method on ZoneMenu panel).

Checks

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits.
  • Fully tokenized all my strings (no hardcoded English strings!!) and supplied bulk JSON strings below

@PeenScreeker PeenScreeker self-assigned this Sep 13, 2024
@PeenScreeker
Copy link
Member Author

@tsa96 made some changes that are worth reviewing again. Specifically, fixed a bug in the teleport section of region details

@tsa96
Copy link
Member

tsa96 commented Sep 17, 2024

Yeah, looks okay. Unsure whether delete or = undefined is best from a javascript-POV here, and if C++ needs the = undefined that's totally fine.

@PeenScreeker
Copy link
Member Author

I changed it thinking that was the problem, but it wasn't. Should have changed it back to delete. Fixed now, thanks for taking a look!

@PeenScreeker PeenScreeker merged commit 3d39fd6 into feat/mom-0.10 Sep 25, 2024
1 check passed
@PeenScreeker PeenScreeker deleted the feat/tp-tracklist branch September 25, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants