September cleanup part 2 #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panzerhandschuh
approved these changes
Sep 17, 2024
- Remove MomentumSpectatorTargetChanged in favor of generic ObserverTargetChanged - Remove currentRunData and currentRunStats from HudComparisons (replaced by MomentumTimer::GetObservedTimerStatus() and GetObservedTimerRunSplits()) - Remove OnMomentumZoneChange (replaced by new timer events) - Remove OnChargeToggled and add enabled value to OnChargeUpdate
jason-e
force-pushed
the
feat/sep-cleanup-pt2-pano
branch
from
9df16ef
to
1b9ca50
Compare
Gocnak
approved these changes
Sep 17, 2024
tsa96
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to go with part 2 of the game code cleanup:
MomentumSpectatorTargetChangedin favor of genericObserverTargetChanged(depends on Add ObserverTargetChanged event StrataSource/pano-typed#24)currentRunDataandcurrentRunStatsfromHudComparisons(replaced byMomentumTimer::GetObservedTimerStatus()andGetObservedTimerRunSplits())OnMomentumZoneChange(replaced by new timer events)OnChargeToggledand addenabledvalue toOnChargeUpdate