-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.10 Map Selector Part 1 #157
Conversation
Dunno what's up with ESLint will fix tomorrow |
78d36f4
to
05fe373
Compare
Moving to a draft for a sec since I want to fixup some stuff from subsequent Panorama PR. Going to just join them together into one PR, they'd be getting reviewed at the same time anyway I can do go better fixuped commits this way. |
Reworked a bunch of stuff, left out gallery changes, though the main map image background is now set in TS rather than C++, since that works a lot better if we go down the in-selector map image route - whatever approach we go with, gallery stuff should be doable with only TS changes. |
05fe373
to
d162611
Compare
I miss Tailwind
Thanks SCell!!
Looks bad, also Pano can capitalize in CSS if needed, stupid (me) doing it in JS
Peen you've probs fixed this already and this'll probs conflict with your stuff, just overwrite.
Wanted the iterator method thingies
Yaaaaay we have to do submodule bumps for P2:CE-only stuff :)
I thought SetDialogVariable was supposed to do this, but isn't working, idk.
This commit resolves a couple of JS exceptions until the builtin typescript compiler can detect const enums in .d.ts files. One of these threw every frame, so worth fixing temporarily. When compilation is fixed, just revert this commit.
TS changes are in the next commit since they're intertwined with all the mapdata stuff.
May have to add eslint plugin for this...
d162611
to
65d06a3
Compare
Sorry, I pushed these changes to a second branch a few days ago that isn't PRed, forgetting that I was going to just combine the two branches together. I know the PR gets bigger but there's a lot fewer changes than if they were split up since I fixuped so much. |
All the Panorama changes corresponding to #2345 on red. Some UI tweaks as well though still slightly WIP, want to get a PR in at a stable point corresponding to the incoming changes on red.
I'll have a subsequent branch on red and here open ASAP, C++ side of that is mostly finished.
Checks
feat: Add foo
,chore: Update bar
, etc...fixup
ed into my original commits.POEditor JSON Strings (if needed)
Made some POEditor additions recently but just added them directly.