Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.10 Map Selector Part 1 #157

Merged
merged 19 commits into from
Nov 28, 2024
Merged

0.10 Map Selector Part 1 #157

merged 19 commits into from
Nov 28, 2024

Conversation

tsa96
Copy link
Member

@tsa96 tsa96 commented Nov 15, 2024

All the Panorama changes corresponding to #2345 on red. Some UI tweaks as well though still slightly WIP, want to get a PR in at a stable point corresponding to the incoming changes on red.

I'll have a subsequent branch on red and here open ASAP, C++ side of that is mostly finished.

Checks

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits.
  • Fully tokenized all my strings (no hardcoded English strings!!) and supplied bulk JSON strings below

POEditor JSON Strings (if needed)

Made some POEditor additions recently but just added them directly.

@tsa96
Copy link
Member Author

tsa96 commented Nov 15, 2024

Dunno what's up with ESLint will fix tomorrow

@tsa96 tsa96 force-pushed the refactor/0.10-map-selector branch 3 times, most recently from 78d36f4 to 05fe373 Compare November 16, 2024 03:24
@tsa96 tsa96 marked this pull request as draft November 21, 2024 08:23
@tsa96
Copy link
Member Author

tsa96 commented Nov 21, 2024

Moving to a draft for a sec since I want to fixup some stuff from subsequent Panorama PR. Going to just join them together into one PR, they'd be getting reviewed at the same time anyway I can do go better fixuped commits this way.

@tsa96 tsa96 marked this pull request as ready for review November 23, 2024 13:46
@tsa96
Copy link
Member Author

tsa96 commented Nov 23, 2024

Reworked a bunch of stuff, left out gallery changes, though the main map image background is now set in TS rather than C++, since that works a lot better if we go down the in-selector map image route - whatever approach we go with, gallery stuff should be doable with only TS changes.

@tsa96 tsa96 force-pushed the refactor/0.10-map-selector branch from 05fe373 to d162611 Compare November 24, 2024 22:51
tsa96 added 17 commits November 24, 2024 22:53
Looks bad, also Pano can capitalize in CSS if needed, stupid (me) doing it in JS
Peen you've probs fixed this already and this'll probs conflict with your stuff, just overwrite.
Wanted the iterator method thingies
Yaaaaay we have to do submodule bumps for P2:CE-only stuff :)
I thought SetDialogVariable was supposed to do this, but isn't working,
idk.
This commit resolves a couple of JS exceptions until the builtin
typescript compiler can detect const enums in .d.ts files. One of these
threw every frame, so worth fixing temporarily.

When compilation is fixed, just revert this commit.
TS changes are in the next commit since they're intertwined with all
the mapdata stuff.
@tsa96 tsa96 force-pushed the refactor/0.10-map-selector branch from d162611 to 65d06a3 Compare November 24, 2024 22:53
@tsa96
Copy link
Member Author

tsa96 commented Nov 24, 2024

Sorry, I pushed these changes to a second branch a few days ago that isn't PRed, forgetting that I was going to just combine the two branches together. I know the PR gets bigger but there's a lot fewer changes than if they were split up since I fixuped so much.

@tsa96 tsa96 merged commit a7c1f44 into feat/mom-0.10 Nov 28, 2024
1 check passed
@tsa96 tsa96 deleted the refactor/0.10-map-selector branch November 28, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants