Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End of run menu for new timer system #167

Merged
merged 12 commits into from
Dec 30, 2024
Merged

End of run menu for new timer system #167

merged 12 commits into from
Dec 30, 2024

Conversation

Panzerhandschuh
Copy link
Member

@Panzerhandschuh Panzerhandschuh commented Dec 28, 2024 •
edited
Loading

Updated the end of run menu to display splits and comparisons from the new timer system.

Checks

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits.
  • Fully tokenized all my strings (no hardcoded English strings!!) and supplied bulk JSON strings below

@Panzerhandschuh Panzerhandschuh force-pushed the feat/more-comparisons branch 2 times, most recently from 253f7cb to 177f29a Compare December 28, 2024 20:13
tsa96
tsa96 requested changes Dec 28, 2024
View reviewed changes
Copy link
Member

@tsa96 tsa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will look through rest of stuff tomorrow because I am sooooo sleepy

scripts/common/timer.ts Outdated Show resolved Hide resolved
@Panzerhandschuh
feat: Add subsegment splits when generating comparison splits
4198028
@Panzerhandschuh
refactor: Improve check for whether positive values on the comparison…
e417d63 
… graph are good

This code will still need further refinement
@Panzerhandschuh
feat: Show end of run comparison after saving the new run
4f60207 
Showing the end of run menu on timer finish might be preferable,
but the timer state change event doesn't include the run time needed
to generate the final zone split.
@Panzerhandschuh
feat: Skip first split and add finish split for runs without a compar…
55bc3db 
…ison
tsa96
tsa96 approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@tsa96 tsa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, so long as you don't want to do end of run subsegment stuff in this PR. No problem leaving it for now, but we shouldn't make the end of run issue (assuming one exists) as completely until that's done.

@Panzerhandschuh Panzerhandschuh merged commit 2fc695b into feat/mom-0.10 Dec 30, 2024
1 check passed
@Panzerhandschuh Panzerhandschuh deleted the feat/more-comparisons branch December 30, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsa96 tsa96 tsa96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Panzerhandschuh @tsa96