Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prime sight fixes #93

Merged
merged 3 commits into from
Jul 1, 2023
Merged

prime sight fixes #93

merged 3 commits into from
Jul 1, 2023

Conversation

PeenScreeker
Copy link
Member

Closes momentum-mod/game/issues/2078
Closes momentum-mod/game/issues/2079

This pull requests fixes a few bugs with the new prime sight hud for defrag.

  • Highlighting now correctly selects the zone behind the crosshair at resolutions other than 1080p.
  • The correct zone is shown when the zone wraps across -pi/pi (reported by lumia & panzer).

Checks

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits.
  • Fully tokenized all my strings (no hardcoded English strings!!) and supplied bulk JSON strings below

@PeenScreeker PeenScreeker self-assigned this Jul 1, 2023
Copy link
Member

@tsa96 tsa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS-wise looks fine, no clue about the maths!

edit: lmao ticked "request changes" by mistake

@Gocnak Gocnak merged commit fd04e4b into master Jul 1, 2023
1 check passed
@Gocnak Gocnak deleted the feat/prime-sight branch July 1, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prime sight highlight selection wrong at non-1080p resolutions prime sight showing wrong zones/freezing
3 participants