Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update audio settings sliders #98

Merged
merged 1 commit into from
Aug 26, 2023
Merged

Conversation

tsa96
Copy link
Member

@tsa96 tsa96 commented Aug 25, 2023

Updates Audio Settings page to work better with the sound system changes brae made a while ago.

  • Rename "Game Volume" to "Master Volume" - clearest term for conveying that it affects everything.
  • Removed "Player Weapon Volume", replaced with "Weapon Volume"
  • Renamed "Overall Weapon Volume" to "Weapon Volume", fixed the convar to use correct one (snd_volume_weapon)
  • Removed "Physics Volume" - nothing really uses this
  • Added "Ghost Volume"

Checks

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits.
  • Fully tokenized all my strings (no hardcoded English strings!!) and supplied bulk JSON strings below

POEditor JSON Strings

[
  {
    "term": "Settings_Volume_Master",
    "definition": "Master Volume"
  },
  {
    "term": "Settings_Volume_Movement",
    "definition": "Player Movement Volume"
  },
  {
    "term": "Settings_Volume_Weapon",
    "definition": "Weapon Volume"
  },
  {
    "term": "Settings_Volume_Ghost",
    "definition": "Ghost Volume"
  },
  {
    "term": "Settings_Volume_Ghost_Info",
    "definition": "Sounds made by online players and replay ghosts. These sounds are also scaled relative to Weapon Volume and Player Movement Volume respectively."
  }
]

@Gocnak Gocnak merged commit 3e5faa3 into master Aug 26, 2023
1 check passed
@Gocnak Gocnak deleted the refactor/settings-sounds branch August 26, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants