Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring most of the project #17

Merged
merged 65 commits into from
Oct 3, 2024
Merged

Conversation

ruslanbaidan
Copy link
Contributor

The code refactoring includes the following parts:

  • Removed the relying on the abstraction and sharing the same methods execution of services.
  • Implemented the single responsibility approach to the entities.I
  • Added the filtering functionality to process the incoming get requests data and prepare them for the filter and sort queries.
  • Added the data validation at first place. Before the post, put, patch and delete requests data are passed to the services, they are validated.
  • Removed the dependency on the abstract table common methods, where the entities positions were processed, and some specific code run.
  • Implemented the common approach, not resources/time consuming, of the entities positioning based on interfaces and traits.
  • Optimised the export and import functionality to be clean and fast.
  • Added a common place to validate the analysis access and endpoints permissions before the controllers’ actions are reached. The Middleware passed an anr object to the actions automatically as an attribute.
  • Restructured the components and code parts of the application for the based on responsibilities, relations and to be more clear.
  • Removed many deprecated code parts and cleaned up the deprecated columns in the DB tables.
  • Improved some DB indexes and renamed tables, columns to be more clear on the names.
  • Added some first unit tests as a starting point for the full coverage.

Not refactored parts are the following: Questions, QuestionsChoices, Guide, Interviews, ROPA, Deliverable.

Ruslan Baidan and others added 30 commits November 11, 2021 11:21
…/master' into 'feature/remove-db-abstract'.
…bstract

* origin/master:
  Updated MONARC title page
  Updated MONARC title page
…bstract

* origin/master:
  Added the "sql_update" parameter only when there is a value to set.
  Fixed the client models unlink.
  Added generation of the update.json files when clients' data are modified, added the new fileds to the creation step.
  fix entity to permit the clear of collection
  The first draft for the user update functionality.
  Fixed the condition error.
  Fixed the code errors.
  Fixed the phinx configuration.
  Added the method return type.
  Updated composer with the versions limit.
  Fixed the dependency dev version use.
  Fixed semantic of composer.json
  Added a condition to only count on countable
  Typo
  Updated composer packages to php8

# Conflicts:
#	composer.json
#	config/module.config.php
#	src/Controller/ApiUserProfileController.php
#	src/Model/Entity/Client.php
#	src/Model/Table/ClientModelTable.php
#	src/Service/ClientService.php
…bstract

* origin/master:
  Added the handeling of the new reset 2FA flag.

# Conflicts:
#	src/Service/ClientService.php
…bstract

* origin/master:
  Fixed all the clients' models unlink when a single one is removed.
  Update ApiUserTwoFAController.php
  Update ClientService.php
  Added the missing space in the sql.
  Added the password reset when 1st user's email is changed.

# Conflicts:
#	src/Model/Table/ClientModelTable.php
#	src/Service/ClientService.php
…bstract

* origin/master:
  Bump tj-actions/changed-files from 12.2 to 41 in /.github/workflows
@ruslanbaidan ruslanbaidan merged commit aada796 into master Oct 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant