Skip to content

Commit 1a67f24

Browse files
github-actions[bot]sabrinatorotwhetzel
authored
Update DOSDP and SPARQL docs (#7759)
* Update DOSDP template and SPARQL qc documentation * fix typos --------- Co-authored-by: sabrinatoro <[email protected]> Co-authored-by: Trish Whetzel <[email protected]>
1 parent 7697b46 commit 1a67f24

File tree

8 files changed

+360
-10523
lines changed

8 files changed

+360
-10523
lines changed

docs/editors-guide/patterns/OMIM_disease_series_by_gene.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,11 @@
55

66

77

8-
This pattern is meant to be used for OMIM Mendelian diseases (ie unitary genetic diseases, as described in [PMID:33417889](https://www.ncbi.nlm.nih.gov/pmc/articles/PMC7820621/)), including children of OMIM phenotypic series (OMIMPS), which are represented as grouping classes in Mondo. Notes about the OMIMPS (see also OMIM_phenotypic_series.yaml): - every instance of the OMIMPS metaclass should be equivalent to (via annotated xref) to something in OMIMPS namespace - the OMIMPS will never have an asserted causative gene as logical axiom (and no single causative gene in text def) - the OMIMPS must never be equivalent to an OMIM:nnnnnn (often redundant with the above rule) - the OMIMPS must have an acronym synonym, e.g. HPE - the OMIMPS must have two or more subclasses (direct or indirect) that are equivalent to OMIMs and conform to this pattern - the subclasses should (not must) have a logical def that uses the PS as a genus - the OMIM subclasses must have acronym synonyms that are the parent syn + number, e.g. HPE1, HPE2 - the primary label for the children should also be parent + {"type"} + number - the first member will usually have the same number local ID as the PS Examples: [holoprosencephaly 1](http://purl.obolibrary.org/obo/MONDO_0009349), [3M syndrome 1](http://purl.obolibrary.org/obo/MONDO_0010117)
8+
This pattern is meant to be used for (1) OMIM Mendelian diseases (ie unitary genetic diseases, as described in [PMID:33417889](https://www.ncbi.nlm.nih.gov/pmc/articles/PMC7820621/)), including children of OMIM phenotypic series (OMIMPS), which are represented as grouping classes in Mondo, and (2) OMIA Mendelian diseases (https://omia.org/) which are defined by a variation in a gene. Notes about the OMIMPS (see also OMIM_phenotypic_series.yaml): - every instance of the OMIMPS metaclass should be equivalent to (via annotated xref) to something in OMIMPS namespace - the OMIMPS will never have an asserted causative gene as logical axiom (and no single causative gene in text def) - the OMIMPS must never be equivalent to an OMIM:nnnnnn (often redundant with the above rule) - the OMIMPS must have an acronym synonym, e.g. HPE - the OMIMPS must have two or more subclasses (direct or indirect) that are equivalent to OMIMs and conform to this pattern - the subclasses should (not must) have a logical def that uses the PS as a genus - the OMIM subclasses must have acronym synonyms that are the parent syn + number, e.g. HPE1, HPE2 - the primary label for the children should also be parent + {"type"} + number - the first member will usually have the same number local ID as the PS Examples: [holoprosencephaly 1](http://purl.obolibrary.org/obo/MONDO_0009349), [3M syndrome 1](http://purl.obolibrary.org/obo/MONDO_0010117)
99
## Contributors
1010
* [https://orcid.org/0000-0002-6601-2165](https://orcid.org/0000-0002-6601-2165)
1111
* [https://orcid.org/0000-0001-5208-3432](https://orcid.org/0000-0001-5208-3432)
12+
* [https://orcid.org/0000-0002-4142-7153](https://orcid.org/0000-0002-4142-7153)
1213
## Name
1314

1415
{[disease](http://purl.obolibrary.org/obo/MONDO_0000001)} caused by variation in {[gene](http://purl.obolibrary.org/obo/SO_0000704)}

docs/editors-guide/patterns/index.md

+4-4
Large diffs are not rendered by default.

docs/editors-guide/quality-control-tests.md

+75-12
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,7 @@ WHERE
263263
"ICD10CM",
264264
"ICD10WHO",
265265
"ICD11",
266+
"icd11.foundation",
266267
"ICD9",
267268
"ICD9CM",
268269
"ICDO",
@@ -350,6 +351,7 @@ WHERE
350351
"ICD10EXP",
351352
"ICD10WHO",
352353
"ICD11",
354+
"icd11.foundation",
353355
"ICD9",
354356
"ICD9CM",
355357
"ICDO",
@@ -362,6 +364,7 @@ WHERE
362364
"MONDO",
363365
"MPATH",
364366
"MTH",
367+
"NANDO",
365368
"NCIT",
366369
"NDFRT",
367370
"NIFSTD",
@@ -965,7 +968,7 @@ SELECT DISTINCT ?entity ?property ?value WHERE {
965968
oboInOwl:hasSynonymType <http://purl.obolibrary.org/obo/mondo#ABBREVIATION> .
966969
}
967970
968-
FILTER NOT EXISTS { ?entity owl:deprecated true }
971+
FILTER NOT EXISTS { ?entity1 owl:deprecated true }
969972
FILTER NOT EXISTS { ?entity2 owl:deprecated true }
970973
FILTER (?entity1 != ?entity2)
971974
FILTER (!isBlank(?entity1))
@@ -1000,6 +1003,32 @@ ORDER BY ?entity
10001003
10011004
```
10021005

1006+
### qc-excluded-subclass.sparql
1007+
1008+
```
1009+
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
1010+
prefix IAO: <http://purl.obolibrary.org/obo/IAO_>
1011+
prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#>
1012+
prefix oio: <http://www.geneontology.org/formats/oboInOwl#>
1013+
prefix def: <http://purl.obolibrary.org/obo/IAO_0000115>
1014+
prefix owl: <http://www.w3.org/2002/07/owl#>
1015+
PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>
1016+
prefix oboInOwl: <http://www.geneontology.org/formats/oboInOwl#>
1017+
1018+
1019+
# Tests if an animal disease made it into the rare disease subset
1020+
1021+
SELECT DISTINCT ?entity ?property ?value
1022+
WHERE
1023+
{
1024+
VALUES ?property { <http://purl.obolibrary.org/obo/mondo#excluded_subClassOf> }
1025+
?entity ?property ?value .
1026+
FILTER(!isIRI(?value) || !STRSTARTS(STR(?value),"http://purl.obolibrary.org/obo/MONDO_"))
1027+
FILTER( !isBlank(?entity) && STRSTARTS(str(?entity), "http://purl.obolibrary.org/obo/MONDO_"))
1028+
}
1029+
1030+
```
1031+
10031032
### qc-illegal-axiom-annotation.sparql
10041033

10051034
```
@@ -1254,7 +1283,6 @@ SELECT DISTINCT ?term ?property WHERE
12541283
dc:conformsTo,
12551284
dc:creator,
12561285
dce:date,
1257-
mondo:confidence,
12581286
mondo:excluded_from_qc_check,
12591287
mondo:excluded_subClassOf,
12601288
mondo:excluded_synonym,
@@ -1293,6 +1321,38 @@ SELECT DISTINCT ?term ?property WHERE
12931321
12941322
```
12951323

1324+
### qc-provenance-missing.sparql
1325+
1326+
```
1327+
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
1328+
prefix IAO: <http://purl.obolibrary.org/obo/IAO_>
1329+
prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#>
1330+
prefix oio: <http://www.geneontology.org/formats/oboInOwl#>
1331+
prefix def: <http://purl.obolibrary.org/obo/IAO_0000115>
1332+
prefix owl: <http://www.w3.org/2002/07/owl#>
1333+
PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>
1334+
prefix oboInOwl: <http://www.geneontology.org/formats/oboInOwl#>
1335+
1336+
1337+
# Tests for excluded_subClassOf relationships that do not also have a source annotation with an ORCID.
1338+
1339+
SELECT DISTINCT ?entity ?property ?value
1340+
WHERE
1341+
{
1342+
VALUES ?property { <http://purl.obolibrary.org/obo/mondo#excluded_subClassOf> }
1343+
?entity ?property ?value .
1344+
FILTER NOT EXISTS {
1345+
[] owl:annotatedSource ?entity ;
1346+
owl:annotatedProperty ?property ;
1347+
owl:annotatedTarget ?value ;
1348+
oboInOwl:source ?orcid .
1349+
FILTER(STRSTARTS(STR(?orcid),"https://orcid.org/"))
1350+
}
1351+
FILTER( !isBlank(?entity) && STRSTARTS(str(?entity), "http://purl.obolibrary.org/obo/MONDO_"))
1352+
}
1353+
1354+
```
1355+
12961356
### qc-proxy-merge-missing-preferred.sparql
12971357

12981358
```
@@ -1570,18 +1630,21 @@ ORDER BY ?entity
15701630
### qc-xref-syntax.sparql
15711631

15721632
```
1573-
# home: hp
1574-
prefix hasDbXref: <http://www.geneontology.org/formats/oboInOwl#hasDbXref>
1575-
prefix oio: <http://www.geneontology.org/formats/oboInOwl#>
1576-
prefix owl: <http://www.w3.org/2002/07/owl#>
1577-
prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#>
1633+
# # Invalid Xref
1634+
#
1635+
# **Problem:** A database_cross_reference is not in CURIE format.
1636+
#
1637+
# **Solution:** Replace the reference with a [CURIE](https://www.w3.org/TR/2010/NOTE-curie-20101216/).
15781638
1579-
SELECT DISTINCT ?entity ?property ?value WHERE
1580-
{
1581-
?entity hasDbXref: ?x .
1639+
PREFIX oboInOwl: <http://www.geneontology.org/formats/oboInOwl#>
1640+
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
15821641
1583-
FILTER( regex(STR(?x), " ") || regex(STR(?x), ";") || STR(?x) = "" )
1584-
BIND(hasDbXref: AS ?property)
1642+
SELECT DISTINCT ?entity ?property ?value
1643+
WHERE {
1644+
VALUES ?property {oboInOwl:hasDbXref}
1645+
?entity ?property ?value .
1646+
FILTER (!regex(?value, "^[A-Za-z_][A-Za-z0-9_.-]*[A-Za-z0-9_]:[^\\s]+$"))
1647+
FILTER (!isBlank(?entity))
15851648
}
15861649
ORDER BY ?entity
15871650

src/patterns/dosdp-patterns/README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@ This is a listing of all the patterns hosted as part of this directory
33

44
## Patterns in dosdp-patterns
55
### Omim disease series by gene
6-
*This pattern is meant to be used for OMIM Mendelian diseases (ie unitary genetic diseases, as described in [PMID:33417889](https://www.ncbi.nlm.nih.gov/pmc/articles/PMC7820621/)), including children of OMIM phenotypic series (OMIMPS), which are represented as grouping classes in Mondo. Notes about the OMIMPS (see also OMIM_phenotypic_series.yaml): - every instance of the OMIMPS metaclass should be equivalent to (via annotated xref) to something in OMIMPS namespace - the OMIMPS will never have an asserted causative gene as logical axiom (and no single causative gene in text def) - the OMIMPS must never be equivalent to an OMIM:nnnnnn (often redundant with the above rule) - the OMIMPS must have an acronym synonym, e.g. HPE - the OMIMPS must have two or more subclasses (direct or indirect) that are equivalent to OMIMs and conform to this pattern - the subclasses should (not must) have a logical def that uses the PS as a genus - the OMIM subclasses must have acronym synonyms that are the parent syn + number, e.g. HPE1, HPE2 - the primary label for the children should also be parent + {"type"} + number - the first member will usually have the same number local ID as the PS Examples: [holoprosencephaly 1](http://purl.obolibrary.org/obo/MONDO_0009349), [3M syndrome 1](http://purl.obolibrary.org/obo/MONDO_0010117)*
6+
*This pattern is meant to be used for (1) OMIM Mendelian diseases (ie unitary genetic diseases, as described in [PMID:33417889](https://www.ncbi.nlm.nih.gov/pmc/articles/PMC7820621/)), including children of OMIM phenotypic series (OMIMPS), which are represented as grouping classes in Mondo, and (2) OMIA Mendelian diseases (https://omia.org/) which are defined by a variation in a gene. Notes about the OMIMPS (see also OMIM_phenotypic_series.yaml): - every instance of the OMIMPS metaclass should be equivalent to (via annotated xref) to something in OMIMPS namespace - the OMIMPS will never have an asserted causative gene as logical axiom (and no single causative gene in text def) - the OMIMPS must never be equivalent to an OMIM:nnnnnn (often redundant with the above rule) - the OMIMPS must have an acronym synonym, e.g. HPE - the OMIMPS must have two or more subclasses (direct or indirect) that are equivalent to OMIMs and conform to this pattern - the subclasses should (not must) have a logical def that uses the PS as a genus - the OMIM subclasses must have acronym synonyms that are the parent syn + number, e.g. HPE1, HPE2 - the primary label for the children should also be parent + {"type"} + number - the first member will usually have the same number local ID as the PS Examples: [holoprosencephaly 1](http://purl.obolibrary.org/obo/MONDO_0009349), [3M syndrome 1](http://purl.obolibrary.org/obo/MONDO_0010117)*
77

88
| Attribute | Info |
99
|----------|----------|
1010
| IRI | http://purl.obolibrary.org/obo/mondo/patterns/disease_series_by_gene.yaml |
1111
| Name | OMIM_disease_series_by_gene |
1212
| Classes | MONDO:0000001, SO:0000704, |
1313
| Variables | disease (MONDO:0000001), gene (SO:0000704), |
14-
| Contributors | [0000-0002-6601-2165](https://orcid.org/0000-0002-6601-2165), [0000-0001-5208-3432](https://orcid.org/0000-0001-5208-3432), |
14+
| Contributors | [0000-0002-6601-2165](https://orcid.org/0000-0002-6601-2165), [0000-0001-5208-3432](https://orcid.org/0000-0001-5208-3432), [0000-0002-4142-7153](https://orcid.org/0000-0002-4142-7153), |
1515
| Examples | |
1616

1717
### Omim phenotypic series

0 commit comments

Comments
 (0)