Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Stargardt disease subclass #8582

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Update Stargardt disease subclass #8582

merged 2 commits into from
Jan 16, 2025

Conversation

yshwetar
Copy link
Collaborator

issue #8580

  • Removed age-related macular degeneration as subclass of Stargardt diease
  • Added excluded subclassof
  • Added ORCID and PMID for evidence

issue #8580

- Removed age-related macular degeneration as subclass of Stargardt diease
- Added excluded subclassof
- Added ORCID and PMID for evidence
is_a: MONDO:0016420 {source="Orphanet:827"} ! familial flecked retinopathy
relationship: excluded_subClassOf MONDO:0005150 {source="PMID:10442900", source="PMID:11346402", source="https://orcid.org/0000-0002-0587-4693"} ! age-related macular degeneration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yshwetar the DOID should be added as a source on the excluded subclass as well, we want to keep the provenance that this came from DO

Copy link
Member

@nicolevasilevsky nicolevasilevsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change needed, thanks!

- Added DOID from original subclass of source to excluded subclass of source
@nicolevasilevsky
Copy link
Member

@yshwetar this can be merged as soon as the checks pass

@nicolevasilevsky nicolevasilevsky merged commit ce4a62b into master Jan 16, 2025
1 check passed
@nicolevasilevsky nicolevasilevsky deleted the issue-8580 branch January 16, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants