adding context types to get and listen methods #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregra81
reviewed
Nov 30, 2023
package.json
Outdated
| @@ -16,6 +16,7 @@ | |||
| "server-sdk.js" | |||
| ], | |||
| "dependencies": { | |||
| "monday-ui-react-core": "^2.63.2", | |||
There was a problem hiding this comment.
this SDK is also used by nodejs servers, so we better only get the types from this package and also move this to devDependencies
gregra81
reviewed
Nov 30, 2023
types/client-context.type.ts
Outdated
| @@ -0,0 +1,238 @@ | |||
| import { Theme } from "monday-ui-react-core/dist/types/components/ThemeProvider/ThemeProviderConstants"; | |||
There was a problem hiding this comment.
Suggested change
| import { Theme } from "monday-ui-react-core/dist/types/components/ThemeProvider/ThemeProviderConstants"; | |
| import type { Theme } from "monday-ui-react-core/dist/types/components/ThemeProvider/ThemeProviderConstants"; |
gregra81
reviewed
Dec 1, 2023
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "monday-sdk-js", | |||
| "version": "0.4.12", | |||
| "version": "0.4.13", | |||
There was a problem hiding this comment.
It's a big change, let's bump to 0.5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overriding settings type depending on you app settings configured in dev center
LISTEN: Typescript override the context with AppFeature[type]Context
GET: Context type without overriding well show the common context type for all feature types
LISTEN: Context type without overriding well show the common context type for all feature types
GET: javascript overriding context type by passing appFeatureType as an option
GET: javascript list of app feature types to get context type based on
