Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return typedef for MondayClientSdk#listen #137

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

grahhnt
Copy link
Contributor

@grahhnt grahhnt commented Jan 2, 2024

MondayClientSdk#listen has a void return type in types/client-data.interface.ts but returns an unlisten function in src/client.js.

This change fixes that and adds JSDoc explaining it

Copy link
Collaborator

@rami-monday rami-monday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grahhnt Looks good, approving

@rami-monday rami-monday merged commit 1aba59f into mondaycom:master Mar 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants