fixing the type of get response #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregra81
approved these changes
Jan 10, 2024
gregra81
reviewed
Jan 11, 2024
There was a problem hiding this comment.
@rami-monday let's remove all the $ExpectType comments as we're not using typescript lint here anyway, so they don't have any influence and they are only confusing
gregra81
reviewed
Jan 11, 2024
Comment on lines
14
to
18
| data.app.id; // $ExpectType number | ||
| data.permissions.approvedScopes; // $ExpectType string[] | ||
| data.theme; // $ExpectType string | ||
| data.boardId; // $ExpectType number | ||
| data.viewMode; // $ExpectType string |
There was a problem hiding this comment.
these assertions are not promising anything about the types of these primitives, i.e. if boardId changes to string, this test won't catch it. I recommend using https://www.npmjs.com/package/expect-type
|
Solves #135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the type of get response from
Responseto{data:Response}