Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add types for open link in tab sdk execute function #93

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

DorShakedMonday
Copy link
Contributor

Copy link
Collaborator

@gregra81 gregra81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 💯.
Let's make sure to merge it only when this capability is in prod

@yuhgto FYI

*/
url: string;
},
): Promise<{ data: any }>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
): Promise<{ data: any }>;
): Promise<{ data: Record<string,any> }>;

@DorShakedMonday DorShakedMonday merged commit d43a87d into master Jun 13, 2023
1 check passed
@DorShakedMonday DorShakedMonday deleted the feat/dorsh/add_support_for_open_link_in_tab branch June 13, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants