feat(WizardSlideshow): component to be used on wizard-related logics to render a step with animation between steps #2557
Conversation
…to render a step with animation between steps
|
@shaharzil @talkor I'm not a big favor of the name I gave to that component, but I think using just Wizard here is too confusing, as it is only responsible on rendering a single child with animation among given children. it does not do any other logic related to Wizard in general |
There was a problem hiding this comment.
I personally don't like the naming. I think it should be a Carousel
There was a problem hiding this comment.
I think carousel is more of a "never ending" thing where you see everything, no?
There was a problem hiding this comment.
btw, it doesn't have to be only slide, this can - in the future - to accept a variation for animation and just be some kind of animation controller
There was a problem hiding this comment.
So it's just Wizard, why the Slideshow? Slideshow sounds like PowerPoint
There was a problem hiding this comment.
I agree, it is just a name I came up with instead of Wizard, since it is not really a wizard, it does nothing else than replacing steps according to a given step
| animate="enter" | ||
| exit="exit" | ||
| transition={slideAnimationTransition} | ||
| className={cx(styles.slide, className)} |
There was a problem hiding this comment.
Does it really need a className?
There was a problem hiding this comment.
for now it would be an internal component, but in case we decide to expose a few animation components next that is an hachana lemazgan, I gave it all the vibe props
export interface SlideTransitionProps extends VibeComponentProps {
There was a problem hiding this comment.
Ok. Anyway notice you are not exporting the other component. Not sure if it's intended or not
WizardSlideshow result:
Original design request:
https://monday.monday.com/boards/3532714909/pulses/7525075588