feat(compass-collection) Fill in the script screen of the Generate Mock Data modal flow #7286
+325
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo-generali
force-pushed
the
CLOUDP-333859-script-output-screen
branch
from
c8dd1ff to
6c55005
Compare
leo-generali
force-pushed
the
CLOUDP-333859-script-output-screen
branch
from
7713d6d to
13a8e9a
Compare
|
@leo-generali Can you provide a screenshot? Not a blocker btw |
kpamaran
reviewed
Sep 5, 2025
| </ul> | ||
| </section> | ||
| <section> | ||
| <Body baseFontSize={16} weight="medium"> |
There was a problem hiding this comment.
nit: I think it's more semantic html to have as="h3" as a prop for this instruction and the other elements of the same weight="medium".
kpamaran
reviewed
Sep 5, 2025
| import { useConnectionInfo } from '@mongodb-js/compass-connections/provider'; | ||
|
|
||
| const RUN_SCRIPT_COMMAND = ` | ||
| mongosh "mongodb+srv://<your-cluster>.mongodb.net/mockDataDB" \\ |
There was a problem hiding this comment.
nit: mockDataDB should be replace with a <your-database>
supernit: the user placeholders should all either be camelCase or hyphen-separated
|
I think it's ready for review @leo-generali. I only had nits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of changes