-
Notifications
You must be signed in to change notification settings - Fork 233
chore: add typecheck to 6 packages #7366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds typecheck functionality to the check scripts for 6 packages as part of COMPASS-8170, ensuring TypeScript type checking includes test files that are normally missed during compilation.
- Added
typecheck
script to 6 package.json files - Updated existing
check
scripts to run typecheck first - Fixed various TypeScript type errors in test files to support proper type checking
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
packages/explain-plan-helper/src/index.spec.ts | Fixed null/undefined handling with optional chaining and non-null assertions |
packages/explain-plan-helper/package.json | Added typecheck script and updated check command |
packages/databases-collections-list/src/index.spec.tsx | Added proper TypeScript types for function parameters and test data |
packages/databases-collections-list/package.json | Added typecheck script and updated check command |
packages/compass-logging/package.json | Added typecheck script and updated check command |
packages/compass-data-modeling/src/components/drawer/relationships-section.tsx | Added CSS overflow properties to button styles |
packages/compass-connections-navigation/src/virtual-list/virtual-list.spec.tsx | Fixed getItemActions return type and added missing getContextMenuGroups prop |
packages/compass-connections-navigation/src/connections-navigation-tree.spec.tsx | Added type assertions for Connection objects |
packages/compass-connections-navigation/package.json | Added typecheck script and updated check command |
packages/compass-app-registry/package.json | Added typecheck script and updated check command |
configs/webpack-config-compass/package.json | Added typecheck script and updated check command |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
maxHeight: 20, // To match accordion line height | ||
overflow: 'hidden', | ||
textOverflow: 'ellipsis', | ||
whiteSpace: 'nowrap', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of COMPASS-8170
Adds
typecheck
to thecheck
of 6 packages. While some typechecking happens on compile, it misses the test files. This will make sure we're catching it.We are still missing typecheck in
mongodb-data-service
and@mongodb-js/compass-components
. Those will require more changes so it'll be better to do them in isolation. Looks like@mongodb-js/compass-crud
also isn't running the right typecheck.