fix(welcome, components): disable guide cues in the app until welcome modal is hidden #7529
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted this issue while debugging an e2e test flake: on a fresh compass install guide cues are awkwardly disaplyed over the welcome modal. Interacting with the modal dismisses both, so you don't know anymore where it was pointing. This patch addresses the issue by disabling guide cues in the app completely until welcome modal is hidden.
Kapture.2025-10-31.at.18.38.41.mp4
Kapture.2025-10-31.at.18.28.44.mp4
The gist of the changes in this patch:
showedNetworkOptIn: only set it totrueafter the modal is closed.ensureDefaultConfigurableUserPreferencesfrom preferences interface and implementation, I couldn't see any reason to have this logic in compass, it just immediately sets some values to slightly different defaults on app start