Skip to content

Conversation

@lerouxb
Copy link
Contributor

@lerouxb lerouxb commented Nov 13, 2025

We somehow missed this in all this time. There's a race condition and the bulk update might still be in progress by the time it checks the toast text.

[2025/11/12 22:24:02.389] FAILURE:  ()
[2025/11/12 22:24:02.389] expected '1 document is being updated.' to include '1 document has been updated.'
[2025/11/12 22:24:02.389] AssertionError: expected '1 document is being updated.' to include '1 document has been updated.'
[2025/11/12 22:24:02.389]     at Context.<anonymous> (tests/collection-bulk-update.test.ts:119:26)
[2025/11/12 22:24:02.389]     at processTicksAndRejections (node:internal/process/task_queues:105:5)

Copilot AI review requested due to automatic review settings November 13, 2025 07:47
@lerouxb lerouxb requested a review from a team as a code owner November 13, 2025 07:47
@lerouxb lerouxb added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Nov 13, 2025
@lerouxb lerouxb requested a review from gribnoysup November 13, 2025 07:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a race condition in the bulk update E2E test where the test was checking the toast message text before the bulk update operation had completed, causing intermittent test failures.

  • Wraps the toast text assertion in a waitUntil to poll for the expected completion message
  • Removes the immediate assertion that was causing the race condition

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@ivandevp ivandevp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lerouxb lerouxb merged commit 3287b4c into main Nov 13, 2025
83 of 86 checks passed
@lerouxb lerouxb deleted the wait-for-toast-text branch November 13, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants