Skip to content

Conversation

lchans
Copy link
Collaborator

@lchans lchans commented Apr 8, 2025

External Links

Description

  • Adds node fields (without variants - these will be implemented in the next PR)

How to test

  1. Run yarn storybook
  2. Click through the stories in the node branch

📸 Screenshots/Screencasts

Screen.Recording.2025-04-09.at.9.15.19.AM.mov

Base automatically changed from feature/MIG-6568-add-node-border to main April 8, 2025 23:24
@lchans lchans force-pushed the feature/MIG-6568-add-fields branch from 4eb7286 to bdbd66a Compare April 8, 2025 23:26
@lchans lchans marked this pull request as ready for review April 8, 2025 23:30
Copy link
Collaborator

@marian-derias marian-derias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except should we add a type to the fields in the Diagram story now so they're consistent with the nodes?
Screenshot 2025-04-09 at 11 07 55 am

@lchans
Copy link
Collaborator Author

lchans commented Apr 9, 2025

LGTM except should we add a type to the fields in the Diagram story now so they're consistent with the nodes? Screenshot 2025-04-09 at 11 07 55 am

Done, buffed up that story a bit

@lchans lchans merged commit e4e17b0 into main Apr 9, 2025
1 check passed
@lchans lchans deleted the feature/MIG-6568-add-fields branch April 9, 2025 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants