feature/MIG-6579 Add preview state to the fields #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shybovycha
approved these changes
Apr 11, 2025
| <InnerFieldName>{name}</InnerFieldName> | ||
| </FieldName> | ||
| <FieldType color={getSecondaryTextColor()}>{type}</FieldType> | ||
| {previewGroupLength ? ( |
There was a problem hiding this comment.
wow, this addresses the bug @adrianhhong discovered yesterday!
context: with our most recently released version, when using wrapped keys, renaming a field in an embedded document or array mapping to _id.*, the renamed field will bubble up to the parent document' _id object
marian-derias
approved these changes
Apr 11, 2025
adrianhhong
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External Links
Description
Notes for Reviewers
yarn storybook📸 Screenshots/Screencasts
preview-border.mov