Skip to content

chore(ci): don't download chrome in bump-auxiliary-packages #2391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025
Merged

chore(ci): don't download chrome in bump-auxiliary-packages #2391

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8aeaa7f
chore(ci): don't download chrome in bump-auxiliary-packages
nirinchev Mar 3, 2025
0bda35b
Add puppeteer variable to publish-auxiliary-packages.yml
nirinchev Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/bump-auxiliary-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@ on:
permissions:
contents: none # We use the github app to checkout and create PR

env:
PUPPETEER_SKIP_DOWNLOAD: "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nice, same can be applied to publish-auxiliary-packages.yml


description: |
This workflow increases the versions of the auxiliary (i.e. non-mongosh) packages and creates a PR
as a first step for a release. Use this workflow when you don't want to do a full mongosh release,
but do need to pick up unreleased changes in one of the @mongosh/* packages.

jobs:
update_generated_files:
name: Bump packages
Expand Down Expand Up @@ -41,8 +49,6 @@ jobs:
- name: Bump packages
run: |
npm run bump-auxiliary
git add .
git commit --no-allow-empty -m "chore(release): bump packages for auxiliary release" || true
Comment on lines -44 to -45
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

peter-evans/create-pull-request already commits all changes, so there's no reason for us to manually do it.


- name: Create Pull Request
uses: peter-evans/create-pull-request@5e914681df9dc83aa4e4905692ca88beb2f9e91f # 7.0.5
Expand Down
Loading