chore(testing): turn the testing folder into a package #2576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Nov 17, 2025
| 'certificates', | ||
| filename | ||
| ); | ||
| return path.join(__dirname, '..', '..', 'testing', 'certificates', filename); |
Collaborator
There was a problem hiding this comment.
Can we make @mongosh/testing export the path to the certificates directory?
gagik
force-pushed
the
gagik/testing-package
branch
from
fe9ac94 to
9b59aaa
Compare
gagik
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR converts the testing directory into a proper package (@mongosh/testing) within the monorepo. This enables explicit dependency management and cleaner imports across packages instead of using relative path-based imports.
Key changes include:
- Moving testing utilities from
testing/topackages/testing/src/ - Creating proper package configuration with TypeScript compilation to
lib/ - Updating all imports across packages from relative paths (
../../../testing/...) to the new package name (@mongosh/testing)
Reviewed Changes
Copilot reviewed 54 out of 88 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| testing/tsconfig.json | Removed old TypeScript config from root testing directory |
| testing/package.json | Removed old package.json from root testing directory |
| packages/testing/tsconfig.json | Added new TypeScript config with compilation to lib/ directory |
| packages/testing/package.json | Created proper package with dependencies and build scripts |
| packages/testing/src/index.ts | Added package entry point exporting utilities and certificate path helper |
| packages/testing/src/integration-testing-hooks.ts | Updated tmpdir path resolution for new location |
| packages/shell-api/src/*.spec.ts | Updated imports to use @mongosh/testing package |
| packages/e2e-tests/test/*.spec.ts | Updated imports to use @mongosh/testing package |
| .evergreen/setup-env.sh | Updated config file path reference |
| .nycrc | Updated coverage exclusion path |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gagik
added
the
no-title-validation
gagik
force-pushed
the
gagik/testing-package
branch
from
b39d4ee to
07b1745
Compare
Co-authored-by: Copilot <[email protected]>
gagik
force-pushed
the
gagik/testing-package
branch
from
07b1745 to
a57a1fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will cleanup our hacky imports and be another step towards having each package explicitly defining its dependencies.