Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump oidc-plugin MONGOSH-2027 #971

Merged
merged 1 commit into from
Mar 4, 2025
Merged

chore(deps): bump oidc-plugin MONGOSH-2027 #971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1350,7 +1350,7 @@
"@babel/preset-typescript": "^7.25.7",
"@babel/types": "^7.25.8",
"@mongodb-js/oidc-mock-provider": "^0.10.2",
"@mongodb-js/oidc-plugin": "^1.1.5",
"@mongodb-js/oidc-plugin": "^1.1.6",
"@mongodb-js/prettier-config-devtools": "^1.0.1",
"@mongodb-js/sbom-tools": "^0.7.2",
"@mongodb-js/signing-utils": "^0.3.8",
Expand Down
76 changes: 38 additions & 38 deletions src/test/suite/connectionController.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,11 @@ suite('Connection Controller Test Suite', function () {
const dataService = testConnectionController.getActiveDataService();

expect(succesfullyConnected).to.be.true;
expect(testConnectionController.getSavedConnections().length).to.equal(1);
expect(testConnectionController.getSavedConnections()).to.have.lengthOf(1);
expect(name).to.equal('localhost:27088');
expect(testConnectionController.isCurrentlyConnected()).to.be.true;

expect(dataService).to.not.equal(null);
expect(dataService).to.not.be.null;
});

test('"disconnect()" disconnects from the active connection', async () => {
Expand Down Expand Up @@ -121,9 +121,9 @@ suite('Connection Controller Test Suite', function () {
);
expect(successfullyDisconnected).to.be.true;
expect(connectionsCount).to.equal(1);
expect(connnectionId).to.equal(null);
expect(connnectionId).to.be.null;
expect(testConnectionController.isCurrentlyConnected()).to.be.false;
expect(dataService).to.equal(null);
expect(dataService).to.be.null;
});

test('"removeMongoDBConnection()" returns a reject promise when there is no active connection', async () => {
Expand All @@ -150,9 +150,9 @@ suite('Connection Controller Test Suite', function () {
} catch (error) {
const expectedError = 'Failed to connect';

expect(formatError(error).message.includes(expectedError)).to.be.true;
expect(testConnectionController.getActiveDataService()).to.equal(null);
expect(testConnectionController.getActiveConnectionId()).to.equal(null);
expect(formatError(error).message).includes(expectedError);
expect(testConnectionController.getActiveDataService()).to.be.null;
expect(testConnectionController.getActiveConnectionId()).to.be.null;
}
});

Expand Down Expand Up @@ -237,7 +237,7 @@ suite('Connection Controller Test Suite', function () {
test('when there are no existing connections in the store and the connection controller loads connections', async () => {
await testConnectionController.loadSavedConnections();

expect(testConnectionController.getSavedConnections().length).to.equal(0);
expect(testConnectionController.getSavedConnections()).to.have.lengthOf(0);
});

test('clears connections when loading saved connections', async () => {
Expand All @@ -261,8 +261,8 @@ suite('Connection Controller Test Suite', function () {

await testConnectionController.loadSavedConnections();

expect(testConnectionController.getSavedConnections().length).to.equal(1);
expect(testConnectionController._connections['1234']).is.undefined;
expect(testConnectionController.getSavedConnections()).to.have.lengthOf(1);
expect(testConnectionController._connections['1234']).to.be.undefined;
});

test('the connection model loads both global and workspace stored connection models', async () => {
Expand Down Expand Up @@ -295,7 +295,7 @@ suite('Connection Controller Test Suite', function () {

const connections = testConnectionController._connections;

expect(Object.keys(connections).length).to.equal(4);
expect(Object.keys(connections)).to.have.lengthOf(4);
expect(connections[Object.keys(connections)[0]].name).to.equal(
'localhost:27088'
);
Expand All @@ -319,7 +319,7 @@ suite('Connection Controller Test Suite', function () {
StorageLocation.GLOBAL
);

expect(Object.keys(globalStoreConnections).length).to.equal(1);
expect(Object.keys(globalStoreConnections)).to.have.lengthOf(1);

const id = Object.keys(globalStoreConnections)[0];

Expand All @@ -331,7 +331,7 @@ suite('Connection Controller Test Suite', function () {
StorageVariables.WORKSPACE_SAVED_CONNECTIONS
);

expect(workspaceStoreConnections).to.equal(undefined);
expect(workspaceStoreConnections).to.be.undefined;
});

test('when a connection is added it is saved to the workspace store', async () => {
Expand All @@ -351,7 +351,7 @@ suite('Connection Controller Test Suite', function () {
StorageLocation.WORKSPACE
);

expect(Object.keys(workspaceStoreConnections).length).to.equal(1);
expect(Object.keys(workspaceStoreConnections)).to.have.lengthOf(1);

const id = Object.keys(workspaceStoreConnections)[0];

Expand All @@ -364,7 +364,7 @@ suite('Connection Controller Test Suite', function () {
StorageLocation.GLOBAL
);

expect(globalStoreConnections).to.equal(undefined);
expect(globalStoreConnections).to.be.undefined;
});

test('a connection can be connected to by id', async () => {
Expand Down Expand Up @@ -402,17 +402,17 @@ suite('Connection Controller Test Suite', function () {
StorageLocation.WORKSPACE
);

expect(Object.keys(workspaceStoreConnections).length).to.equal(1);
expect(Object.keys(workspaceStoreConnections)).to.have.lengthOf(1);

await testConnectionController.disconnect();
testConnectionController.clearAllConnections();

expect(testConnectionController.getSavedConnections().length).to.equal(0);
expect(testConnectionController.getSavedConnections()).to.have.lengthOf(0);

// Activate (which will load the past connection).
await testConnectionController.loadSavedConnections();

expect(testConnectionController.getSavedConnections().length).to.equal(1);
expect(testConnectionController.getSavedConnections()).to.have.lengthOf(1);

const id = testConnectionController.getSavedConnections()[0].id;

Expand All @@ -435,7 +435,7 @@ suite('Connection Controller Test Suite', function () {

const activeConnectionId = testConnectionController.getActiveConnectionId();

expect(activeConnectionId).to.not.equal(null);
expect(activeConnectionId).to.not.be.null;

const testDriverUrl =
testConnectionController.copyConnectionStringByConnectionId(
Expand Down Expand Up @@ -482,16 +482,16 @@ suite('Connection Controller Test Suite', function () {
}
);

expect(expectedUndefinedDeviceFlow).to.equal(undefined);
expect(expectedUndefinedDeviceFlow).to.be.undefined;

const oidcConnectionString = new ConnectionString(TEST_DATABASE_URI);
oidcConnectionString.searchParams.set('authMechanism', 'MONGODB-OIDC');

const expectedFunction = getNotifyDeviceFlowForConnectionAttempt({
connectionString: oidcConnectionString.toString(),
});
expect(expectedFunction).to.not.equal(undefined);
expect(showInformationMessageStub.called).to.equal(false);
expect(expectedFunction).to.not.be.undefined;
expect(showInformationMessageStub.called).to.be.false;

(
expectedFunction as (deviceFlowInformation: {
Expand Down Expand Up @@ -525,7 +525,7 @@ suite('Connection Controller Test Suite', function () {
StorageLocation.WORKSPACE
);

expect(Object.keys(workspaceStoreConnections).length).to.equal(1);
expect(Object.keys(workspaceStoreConnections)).to.have.lengthOf(1);

const connectionId =
testConnectionController.getActiveConnectionId() || 'a';
Expand All @@ -538,7 +538,7 @@ suite('Connection Controller Test Suite', function () {
StorageLocation.WORKSPACE
);

expect(Object.keys(postWorkspaceStoreConnections).length).to.equal(0);
expect(Object.keys(postWorkspaceStoreConnections)).to.have.lengthOf(0);
});

test('when a connection is removed it is also removed from global storage', async () => {
Expand All @@ -555,7 +555,7 @@ suite('Connection Controller Test Suite', function () {
StorageLocation.GLOBAL
);

expect(Object.keys(globalStoreConnections).length).to.equal(1);
expect(Object.keys(globalStoreConnections)).to.have.lengthOf(1);

const connectionId =
testConnectionController.getActiveConnectionId() || 'a';
Expand All @@ -566,7 +566,7 @@ suite('Connection Controller Test Suite', function () {
StorageLocation.GLOBAL
);

expect(Object.keys(postGlobalStoreConnections).length).to.equal(0);
expect(Object.keys(postGlobalStoreConnections)).to.have.lengthOf(0);
});

test('when a connection is removed, the secrets for that connection are also removed', async () => {
Expand Down Expand Up @@ -601,7 +601,7 @@ suite('Connection Controller Test Suite', function () {
StorageLocation.WORKSPACE
);

expect(Object.keys(workspaceStoreConnections).length).to.equal(1);
expect(Object.keys(workspaceStoreConnections)).to.have.lengthOf(1);

const connectionId =
testConnectionController.getActiveConnectionId() || 'zz';
Expand All @@ -620,12 +620,12 @@ suite('Connection Controller Test Suite', function () {

testConnectionController.clearAllConnections();

expect(testConnectionController.getSavedConnections().length).to.equal(0);
expect(testConnectionController.getSavedConnections()).to.have.lengthOf(0);

// Activate (which will load the past connection).
await testConnectionController.loadSavedConnections();

expect(testConnectionController.getSavedConnections().length).to.equal(1);
expect(testConnectionController.getSavedConnections()).to.have.lengthOf(1);

const id = testConnectionController.getSavedConnections()[0].id;
const name = testConnectionController._connections[id || 'x'].name;
Expand All @@ -650,7 +650,7 @@ suite('Connection Controller Test Suite', function () {
StorageLocation.WORKSPACE
);

expect(Object.keys(workspaceStoreConnections).length).to.equal(1);
expect(Object.keys(workspaceStoreConnections)).to.have.lengthOf(1);

const connectionId =
testConnectionController.getActiveConnectionId() || 'zz';
Expand All @@ -671,12 +671,12 @@ suite('Connection Controller Test Suite', function () {

testConnectionController.clearAllConnections();

expect(testConnectionController.getSavedConnections().length).to.equal(0);
expect(testConnectionController.getSavedConnections()).to.have.lengthOf(0);

// Activate (which will load the past connection).
await testConnectionController.loadSavedConnections();

expect(testConnectionController.getSavedConnections().length).to.equal(1);
expect(testConnectionController.getSavedConnections()).to.have.lengthOf(1);

const id = testConnectionController.getSavedConnections()[0].id;
const connectTimeoutMS = new ConnectionString(
Expand Down Expand Up @@ -732,7 +732,7 @@ suite('Connection Controller Test Suite', function () {
const connections = testConnectionController._connections;
const connectionIds = Object.keys(connections);

expect(connectionIds.length).to.equal(2);
expect(connectionIds).to.have.lengthOf(2);
expect(connections[connectionIds[0]].name).to.equal('localhost:27088');
expect(connections[connectionIds[1]].name).to.equal('localhost:27088');

Expand All @@ -748,12 +748,12 @@ suite('Connection Controller Test Suite', function () {

await testConnectionController.loadSavedConnections();

expect(connectionIds.length).to.equal(2);
expect(connectionIds).to.have.lengthOf(2);

const connectionQuickPicks =
testConnectionController.getConnectionQuickPicks();

expect(connectionQuickPicks.length).to.equal(3);
expect(connectionQuickPicks).to.have.lengthOf(3);
expect(connectionQuickPicks[0].label).to.equal('Add new connection');
expect(connectionQuickPicks[1].label).to.equal('localhost:27088');
expect(connectionQuickPicks[2].label).to.equal('Lynx');
Expand Down Expand Up @@ -915,7 +915,7 @@ suite('Connection Controller Test Suite', function () {
await testConnectionController.loadSavedConnections();

const connections = testConnectionController.getSavedConnections();
expect(connections.length).to.equal(1);
expect(connections).to.have.lengthOf(1);

const newSavedConnectionInfoWithSecrets =
await testConnectionController._connectionStorage._getConnectionInfoWithSecrets(
Expand Down Expand Up @@ -944,7 +944,7 @@ suite('Connection Controller Test Suite', function () {
expect(workspaceStoreConnections).to.not.be.empty;
const connections = Object.values(workspaceStoreConnections);

expect(connections.length).to.equal(1);
expect(connections).to.have.lengthOf(1);
expect(connections[0].connectionOptions?.connectionString).to.include(
TEST_USER_USERNAME
);
Expand All @@ -971,7 +971,7 @@ suite('Connection Controller Test Suite', function () {
const mongoClientConnectionOptions =
testConnectionController.getMongoClientConnectionOptions();

expect(mongoClientConnectionOptions).to.not.equal(undefined);
expect(mongoClientConnectionOptions).to.not.be.undefined;

// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
delete mongoClientConnectionOptions!.options.parentHandle;
Expand Down
Loading