[LG-4631] fix 500 page crash when required prop is deselected #407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LG-4631
In the live example pages, when a knob uses a
Select
to set the prop value,allowDeselect={true}
by default. However, the prop value of a deselected option is""
which in some cases will throw an error and crash the page. Specifically for theCode
component, deselecting thelanguage
prop would setlanguage=""
which is an invalid prop.This change will set
allowDeselect={false}
for all knobs with control type of'radio'
. For props likelanguage
that cannot be deselected, the appropriate storybook control in the storybook file must be set totype: 'radio'
.in
*.stories.tsx