DOCSP-40801: Count documents #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustagir
approved these changes
Jul 1, 2024
source/includes/read/count.cpp
Outdated
| // Counts documents that have a "founded_year" value of 2010 | ||
| // start-count-accurate | ||
| auto result = collection.count_documents(make_document(kvp("founded_year", 2010))); | ||
| std::cout << "Number of documents: " << result << std::endl; |
There was a problem hiding this comment.
S: give more descrriptive output
Suggested change
| std::cout << "Number of documents: " << result << std::endl; | |
| std::cout << "Number of companies founded in 2010: " << result << std::endl; |
source/read/count.txt
Outdated
Comment on lines
63
to
65
| .. code-block:: cpp | ||
|
|
||
| auto count = collection.count_documents({}) |
There was a problem hiding this comment.
Q: why not include this in the code file as well? Also why not include a print statement?
There was a problem hiding this comment.
moved to the code file & added output - it seemed like a basic syntax example, but I think it still benefits from those changes
source/read/count.txt
Outdated
|
|
||
| .. output:: | ||
|
|
||
| Number of documents: 100 |
There was a problem hiding this comment.
S: make output more descriptive
eramongodb
requested changes
Jul 2, 2024
Comment on lines
+43
to
+44
| To learn how to create a free MongoDB Atlas cluster and load the sample datasets, see the | ||
| :ref:`<cpp-get-started>` tutorial. |
There was a problem hiding this comment.
Is this reference correct? I do not think the "Get Started with the C++ Driver" pages are relevant to creating a free MongoDB Atlas cluster.
| // start-modify-accurate | ||
| mongocxx::options::count opts; | ||
| opts.limit(100); | ||
| auto result = collection.count_documents(make_document(kvp("number_of_employees", 50))); |
There was a problem hiding this comment.
Suggested change
| auto result = collection.count_documents(make_document(kvp("number_of_employees", 50))); | |
| auto result = collection.count_documents(make_document(kvp("number_of_employees", 50)), opts); |
Missing opts argument specifying the limit set above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-40801
Staging - https://preview-mongodbnorareidy.gatsbyjs.io/cpp-driver/DOCSP-40801-count/read/count/
Self-Review Checklist