DOCSP-46664-Repetitive-paths #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-relational-migrator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ltran-mdb2
reviewed
Jan 22, 2025
There was a problem hiding this comment.
Thanks for picking this up @mayaraman19 ! I just left a question for your consideration.
config/redirects
Outdated
|
|
||
| # Repetitive paths | ||
| [*]: ${prefix}/jobs/data-verification/data-verification/ -> ${base}/relational-migrator/data-verification/ |
There was a problem hiding this comment.
[question] should the redirect have "jobs" in the path?
Suggested change
| [*]: ${prefix}/jobs/data-verification/data-verification/ -> ${base}/relational-migrator/data-verification/ | |
| [*]: ${prefix}/jobs/data-verification/data-verification/ -> ${base}/relational-migrator/jobs/data-verification/ |
There was a problem hiding this comment.
whoops ... thank you for catching 😬
mayaraman19
changed the title
mayaraman19
commented
Jan 22, 2025
config/redirects
Outdated
Comment on lines
29
to
31
| [*]: ${prefix}/jobs/data-verification/data-verification/ -> ${base}/relational-migrator/jobs/data-verification/ | ||
| [*]: ${prefix}/mapping-rules/fields/calculated-fields/calculated-fields/ -> ${base}/relational-migrator/mapping-rules/fields/calculated-fields/ | ||
| # DOCSP-46661 Repetitive File Paths End |
There was a problem hiding this comment.
reviewer: pls lmk if putting it in between these comments is incorrect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
/jobs/data-verification/data-verification/ -> /jobs/data-verification/
/mapping-rules/fields/calculated-fields/calculated-fields/ -> /mapping-rules/fields/calculated-fields/
and redirects and vale dependency
STAGING
https://deploy-preview-193--docs-relational-migrator.netlify.app/jobs/data-verification/
https://deploy-preview-193--docs-relational-migrator.netlify.app/mapping-rules/fields/calculated-fields/
Mut output:
JIRA
https://jira.mongodb.org/browse/DOCSP-46664
BUILD LOG
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?