Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-46660-repetitive-paths #199

Merged
merged 6 commits into from
Jan 23, 2025
Merged

Conversation

ltran-mdb2
Copy link
Collaborator

@ltran-mdb2 ltran-mdb2 commented Jan 23, 2025

DESCRIPTION

Fixes the following repetitive paths:
https://www.mongodb.com/docs/relational-migrator/diagrams/diagrams/
https://www.mongodb.com/docs/relational-migrator/diagrams/navigate-diagrams/navigate-diagrams/
https://www.mongodb.com/docs/relational-migrator/connection-strings/connection-strings/

Also fixes build errors from #195

STAGING

https://deploy-preview-199--docs-relational-migrator.netlify.app/diagrams/
https://deploy-preview-199--docs-relational-migrator.netlify.app/connection-strings/
https://deploy-preview-199--docs-relational-migrator.netlify.app/diagrams/navigate-diagrams/

Result of mut-redirects config/redirects:
Redirect 301 /docs/relational-migrator/diagrams/diagrams/
https://www.mongodb.com/docs/relational-migrator/diagrams/

Redirect 301 /docs/relational-migrator/diagrams/navigate-diagrams/navigate-diagrams/ https://www.mongodb.com/docs/relational-migrator/diagrams/navigate-diagrams/

Redirect 301 /docs/relational-migrator/connection-strings/connection-strings/
https://www.mongodb.com/docs/relational-migrator/connection-strings/

JIRA

https://jira.mongodb.org/browse/DOCSP-46660

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for docs-relational-migrator ready!

Name Link
🔨 Latest commit faaa35b
🔍 Latest deploy log https://app.netlify.com/sites/docs-relational-migrator/deploys/6792a9e91944a60008a46e5b
😎 Deploy Preview https://deploy-preview-199--docs-relational-migrator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 29 (🔴 down 15 from production)
Accessibility: 85 (no change from production)
Best Practices: 75 (no change from production)
SEO: 83 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ltran-mdb2 ltran-mdb2 closed this Jan 23, 2025
@ltran-mdb2 ltran-mdb2 reopened this Jan 23, 2025
@ltran-mdb2 ltran-mdb2 requested a review from ajhuh-mdb January 23, 2025 18:20
Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment!

@@ -150,9 +150,9 @@ Explore libraries and tools for MongoDB.
Database Connections </database-connections/database-connections>

Projects </projects>
Mapping Rules </mapping-rules/mapping-rules>
Mapping Rules </mapping-rules/introduction>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] just a heads up, I think we'll want to also add this page onto the snooty.toml file for toc landing pages.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@ltran-mdb2 ltran-mdb2 merged commit 6f42149 into mongodb:master Jan 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants