-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-47557 Refactors projects section #236
Conversation
✅ Deploy Preview for docs-relational-migrator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for taking on this large amount of work @jwilson-mdb, this is a super solid start! I left some comments for style, consistency, and clarity, so feel free to let me know if there's anything here you want to discuss!
Thanks so much for the review @ajhuh-mdb! For the original changes, I was primarily focused on re-arranging existing content to the new IA. Your suggested updates to the content definitely improved the end result. Please let me know if I missed anything, or if you catch anything else when you re-review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these updates @jwilson-mdb. I think this looks a lot clearer :-) Just a couple more small comments before this should be ready to go!
source/projects/manage-projects.txt
Outdated
|
||
Delete a project to remove migration workloads that are no longer needed. | ||
|
||
- If the last project on the :guilabel:`Recent Projects` page is deleted, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[suggestion] Since this is a standalone list item, I think we can just make it into a sentence that isn't bulleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ✅ thanks for all the work you're doing on this relational migrator uplift, it's looking great!
LGTM'd by PM in review session |
8f46669
to
958dc41
Compare
DESCRIPTION
Refactors the projects section content.
Specifically:
Note for Reviewer
The build log contains many
Page not included in any toctree...
errorsSTAGING
source/projects.txt
source/projects/manage-projects.txt
source/installation/application-settings.txt
Contains no new content, just moves it into a new file... procedure::
to stay parallel withManage Projects
JIRA
https://jira.mongodb.org/browse/DOCSP-47557
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?