Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-47557 Refactors projects section #236

Merged
merged 9 commits into from
Mar 25, 2025

Conversation

jwilson-mdb
Copy link
Collaborator

@jwilson-mdb jwilson-mdb commented Mar 19, 2025

DESCRIPTION

Refactors the projects section content.

Specifically:

  • Updates "Manage Projects" page to parallel Manage Connections format
  • Updates titles and ToC labels
  • Updates content on landing page to reflect these changes
  • Moves Application-wide settings to the new "Application Settings" page

Note for Reviewer
The build log contains many Page not included in any toctree... errors

  • Unused pages will be removed in DOCSP-47546
    • Pages are being left in place for now to facilitate:
      • content reorganization updates
      • creation of redirects before publishing feature branch

STAGING

JIRA

https://jira.mongodb.org/browse/DOCSP-47557

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

Copy link

netlify bot commented Mar 19, 2025

Deploy Preview for docs-relational-migrator ready!

Name Link
🔨 Latest commit 958dc41
🔍 Latest deploy log https://app.netlify.com/sites/docs-relational-migrator/deploys/67e2e4541ceb110008b84ab7
😎 Deploy Preview https://deploy-preview-236--docs-relational-migrator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 29 (🔴 down 43 from production)
Accessibility: 85 (🔴 down 13 from production)
Best Practices: 75 (no change from production)
SEO: 75 (🔴 down 8 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for taking on this large amount of work @jwilson-mdb, this is a super solid start! I left some comments for style, consistency, and clarity, so feel free to let me know if there's anything here you want to discuss!

@jwilson-mdb
Copy link
Collaborator Author

Thanks so much for the review @ajhuh-mdb! For the original changes, I was primarily focused on re-arranging existing content to the new IA. Your suggested updates to the content definitely improved the end result.

Please let me know if I missed anything, or if you catch anything else when you re-review!

@jwilson-mdb jwilson-mdb requested a review from ajhuh-mdb March 21, 2025 22:24
Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates @jwilson-mdb. I think this looks a lot clearer :-) Just a couple more small comments before this should be ready to go!


Delete a project to remove migration workloads that are no longer needed.

- If the last project on the :guilabel:`Recent Projects` page is deleted, the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] Since this is a standalone list item, I think we can just make it into a sentence that isn't bulleted.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@jwilson-mdb jwilson-mdb requested a review from ajhuh-mdb March 24, 2025 20:15
Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ✅ thanks for all the work you're doing on this relational migrator uplift, it's looking great!

@jwilson-mdb
Copy link
Collaborator Author

LGTM'd by PM in review session

@jwilson-mdb jwilson-mdb merged commit 3db489f into mongodb:docs-uplift Mar 25, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants