DOCSP-48539-PreMigration-Analysis-API-endpoints #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-relational-migrator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mmaville-mdb
commented
Mar 20, 2025
mmaville-mdb
commented
Mar 20, 2025
ajhuh-mdb
approved these changes
Mar 20, 2025
There was a problem hiding this comment.
Thanks for making these updates @mmaville-mdb! 😄 Just a few comments to address before this should be ready to go with external review.
ajhuh-mdb
requested changes
Mar 20, 2025
ajhuh-mdb
reviewed
Mar 21, 2025
| "database-type": { | ||
| "type": "string" | ||
| "description": "Database type or a custom database type. For example, `MYSQL`, `ORACLE`, `POSTGRESQL`, `SQL_SERVER`, `COCKROACHDB`, `DB2`, `SQLANYWHERE`, `SYBASE`, `SYBASEIQ`, or `YUGABYTE`.", |
There was a problem hiding this comment.
[praise] This seems much clearer! 🚀
ajhuh-mdb
approved these changes
Mar 21, 2025
|
LGTM from Avinash via slack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
Adding Pre-Migration Analysis endpoints to the Relational Migrator API documentation.
This content is generated from mongodb-ets/migrator. I'll have the team edit the source and generate new output with corrections after initial copy review.
STAGING
https://deploy-preview-237--docs-relational-migrator.netlify.app/api-docs/rest-api-spec/
JIRA
https://jira.mongodb.org/browse/DOCSP-48539
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?