Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCSP-45184-ruby-replica-sets #119

Merged
merged 14 commits into from
Jan 16, 2025
Merged

DOCSP-45184-ruby-replica-sets #119

merged 14 commits into from
Jan 16, 2025

Conversation

gmiller-mdb
Copy link
Contributor

@gmiller-mdb gmiller-mdb commented Jan 7, 2025 •
edited by github-actions bot
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-45184

Staging Links

  • read-write-pref
  • index

    • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    @netlify Netlify
    Copy link

    netlify bot commented Jan 7, 2025 •
    edited
    Loading

    ✅ Deploy Preview for docs-ruby ready!

    Name Link
    🔨 Latest commit 3c79f91
    🔍 Latest deploy log https://app.netlify.com/sites/docs-ruby/deploys/678965410424c00008ec5fc8
    😎 Deploy Preview https://deploy-preview-119--docs-ruby.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    jordan-smith721
    jordan-smith721 requested changes Jan 8, 2025
    View reviewed changes
    Copy link
    Collaborator

    @jordan-smith721 jordan-smith721 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Nice work! Just some style guide fixes and some suggestions!

    source/read-write-pref.txt Outdated Show resolved Hide resolved
    source/read-write-pref.txt Outdated Show resolved Hide resolved
    source/read-write-pref.txt Outdated Show resolved Hide resolved
    source/read-write-pref.txt Outdated Show resolved Hide resolved
    source/read-write-pref.txt Outdated Show resolved Hide resolved
    source/read-write-pref.txt Outdated Show resolved Hide resolved
    source/read-write-pref.txt Outdated Show resolved Hide resolved
    source/read-write-pref.txt Outdated Show resolved Hide resolved
    source/read-write-pref.txt Outdated Show resolved Hide resolved
    source/read-write-pref.txt Outdated Show resolved Hide resolved
    jordan-smith721
    jordan-smith721 requested changes Jan 14, 2025
    View reviewed changes
    Copy link
    Collaborator

    @jordan-smith721 jordan-smith721 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Just a few more things!

    source/read-write-pref.txt Outdated Show resolved Hide resolved
    source/read-write-pref.txt Outdated Show resolved Hide resolved
    source/read-write-pref.txt Outdated Show resolved Hide resolved
    source/read-write-pref.txt Outdated
    Comment on lines 141 to 142
    For more information about aggregates, see the `ruby-aggregation <https://www.mongodb.com/docs/ruby-driver/upcoming/reference/aggregation/>`_
    page.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Bumping this comment since it's still a hard-coded link

    source/read-write-pref.txt Outdated Show resolved Hide resolved
    source/read-write-pref.txt Outdated Show resolved Hide resolved
    source/read-write-pref.txt Outdated Show resolved Hide resolved
    source/read-write-pref.txt Outdated Show resolved Hide resolved
    jordan-smith721
    jordan-smith721 approved these changes Jan 14, 2025
    View reviewed changes
    Copy link
    Collaborator

    @jordan-smith721 jordan-smith721 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM w/ a few more quick things!

    source/read-write-pref.txt Outdated
    Comment on lines 121 to 122
    .. note::
    Lower read concern level requirements may reduce latency.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Bumping this

    source/read-write-pref.txt Outdated Show resolved Hide resolved
    source/read-write-pref.txt Outdated Show resolved Hide resolved
    source/read-write-pref.txt Outdated Show resolved Hide resolved
    @gmiller-mdb gmiller-mdb requested review from alexbevi and jamis January 14, 2025 19:31
    jamis
    jamis approved these changes Jan 16, 2025
    View reviewed changes
    Copy link
    Contributor

    @jamis jamis left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Just some stylistic considerations. 👍

    source/includes/usage-examples/read-write-pref.rb Outdated Show resolved Hide resolved
    source/includes/usage-examples/read-write-pref.rb Outdated Show resolved Hide resolved
    source/includes/usage-examples/read-write-pref.rb Outdated Show resolved Hide resolved
    source/includes/usage-examples/read-write-pref.rb Show resolved Hide resolved
    source/includes/usage-examples/read-write-pref.rb Outdated Show resolved Hide resolved
    @gmiller-mdb gmiller-mdb merged commit 6ab7cf9 into mongodb:standardization Jan 16, 2025
    5 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @jordan-smith721 jordan-smith721 jordan-smith721 approved these changes

    @jamis jamis jamis approved these changes

    @alexbevi alexbevi Awaiting requested review from alexbevi

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @gmiller-mdb @jamis @jordan-smith721