Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-45192-read-data-page #128

Merged

Conversation

gmiller-mdb
Copy link
Contributor

@gmiller-mdb gmiller-mdb commented Jan 14, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-45192

Staging Links

  • read
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Jan 14, 2025

    Deploy Preview for docs-ruby ready!

    Name Link
    🔨 Latest commit 8f8396d
    🔍 Latest deploy log https://app.netlify.com/sites/docs-ruby/deploys/678981c4b446e600088c6584
    😎 Deploy Preview https://deploy-preview-128--docs-ruby.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Contributor

    @rachel-mack rachel-mack left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    A few things:

    source/read.txt Outdated Show resolved Hide resolved
    source/includes/usage-examples/read-code-examples.rb Outdated Show resolved Hide resolved
    source/read.txt Outdated Show resolved Hide resolved
    source/read.txt Outdated
    Comment on lines 169 to 170
    .. TODO
    .. To learn more about the ``watch()`` method, see the :ref:`Monitor Data Changes <ruby-change-streams>` guide.
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Should this still be commented out? A link to at least the API does here would be nice.

    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This is the only page that hasn't been merged yet, the link should work soon- I can just put it back with the broken link since the fix is imminent?

    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Yup, just wanted to make sure it wasn't an oversight

    @gmiller-mdb gmiller-mdb requested review from alexbevi and jamis January 15, 2025 18:58
    source/includes/usage-examples/read-code-examples.rb Outdated Show resolved Hide resolved
    source/includes/usage-examples/sample-read-app.rb Outdated Show resolved Hide resolved
    source/includes/usage-examples/sample-read-app.rb Outdated Show resolved Hide resolved
    @gmiller-mdb gmiller-mdb merged commit ac9d73b into mongodb:standardization Jan 16, 2025
    5 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants