fix(ci): fix packaging of the segment key INTELLIJ-148 #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
nirinchev
approved these changes
Dec 11, 2024
buildSrc/src/main/kotlin/com.mongodb.intellij.plugin-component.gradle.kts
Outdated
Show resolved
Hide resolved
| @@ -120,12 +120,14 @@ jmhReport { | |||
| } | |||
|
|
|||
| tasks { | |||
| register("buildProperties", WriteProperties::class) { | |||
| group = "build" | |||
| if (pluginBundle.enableBundle.get() == true) { | |||
There was a problem hiding this comment.
What is this condition checking?
There was a problem hiding this comment.
It checks if this is the plugin, basically, or a plugin component. For the jetbrains-plugin package this is true, so we bundle the segment api key, if it's not (like the datagrip package) it just discards this task.
… with the UI tests in favour of assertj
github-actions
bot
added
fix
github-actions
bot
added
fix
github-actions
bot
added
fix
|
🤖 Benchmark Comparison for
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Open Questions