LG-4789: Chat MessageFeed Scroll to Latest Button #2648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 291e271 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stephl3
reviewed
Jan 22, 2025
| // Wait until scroll animation completes | ||
| scrollTimerRef.current = setTimeout(() => { | ||
| setShowScrollButton(!isScrolledToEnd()); | ||
| }, 100); |
There was a problem hiding this comment.
is this an arbitrary value or does it correspond with a transition duration? can we make it a constant to better capture why we use 100?
There was a problem hiding this comment.
Currently arbitrary, though it works fine on the longest messages that our chatbot returns - scrollTo is pretty quick.
Longer term I'd like to explore making this not use a timer and instead run on scroll end. However, the scrollend event isn't supported in Safari and there isn't a built-in callback so the timer will have to do for now.
stephl3
reviewed
Jan 22, 2025
There was a problem hiding this comment.
@nlarew there's an issue with our lint check in CI that we need to check out. In the meantime, can you run pnpm fix locally to fix these lint issues: https://github.com/mongodb/leafygreen-ui/actions/runs/12916471164/job/36021239154?pr=2648
|
Size Change: +1.79 kB (+0.13%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
stephl3
reviewed
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: LG-4789
✅ Checklist
For bug fixes, new features & breaking changes
pnpm changesetand documented my changesFor new components
🧪 How to test changes
scroll-to-latest.mov