[LG-5794] chore: Added id prop support for ConfirmationModel buttons #3362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3c8d334 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Size Change: 0 B Total Size: 1.81 MB ℹ️ View Unchanged
|
adamrasheed
requested review from
TheSonOfThomp,
Copilot and
shaneeza
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the id prop on ConfirmationModal buttons by switching from BaseButtonProps to ButtonProps. The change enables consumers to pass standard HTML button attributes like id through confirmButtonProps and cancelButtonProps.
Key changes:
- Updated button prop types from
BaseButtonPropstoButtonProps<'button'>to include standard HTML button attributes - Enhanced the
onClicksignature to accept optionalMouseEvent | KeyboardEventparameters - Added comprehensive test coverage for the new
idprop functionality
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/confirmation-modal/src/ConfirmationModal/ConfirmationModal.types.ts | Updated button prop types from BaseButtonProps to ButtonProps, added ButtonOnlyProps type to filter anchor-specific props, and updated onClick signature |
| packages/confirmation-modal/src/ConfirmationModal/ConfirmationModal.spec.tsx | Added tests for id prop propagation and custom onClick handlers with event parameters |
| .changeset/itchy-experts-relax.md | Documented the breaking change for the minor version bump |
packages/confirmation-modal/src/ConfirmationModal/ConfirmationModal.types.ts
Outdated
Show resolved
Hide resolved
packages/confirmation-modal/src/ConfirmationModal/ConfirmationModal.spec.tsx
Outdated
Show resolved
Hide resolved
shaneeza
reviewed
Dec 8, 2025
packages/confirmation-modal/src/ConfirmationModal/ConfirmationModal.spec.tsx
Show resolved
Hide resolved
packages/confirmation-modal/src/ConfirmationModal/ConfirmationModal.spec.tsx
Outdated
Show resolved
Hide resolved
packages/confirmation-modal/src/ConfirmationModal/ConfirmationModal.spec.tsx
Outdated
Show resolved
Hide resolved
packages/confirmation-modal/src/ConfirmationModal/ConfirmationModal.spec.tsx
Outdated
Show resolved
Hide resolved
packages/confirmation-modal/src/ConfirmationModal/ConfirmationModal.types.ts
Outdated
Show resolved
Hide resolved
13 tasks
shaneeza
reviewed
Dec 10, 2025
packages/confirmation-modal/src/ConfirmationModal/ConfirmationModal.types.ts
Outdated
Show resolved
Hide resolved
shaneeza
reviewed
Dec 10, 2025
Collaborator
There was a problem hiding this comment.
Sorry, one more thing. I think we should also add some tests in the types behave as expected block that verifies you can pass an ID and that the href is not accepted.
Contributor
|
Coverage after merging ar/LG-5794-button into main will be
Coverage Report for Changed Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Adds support for the
idprop on ConfirmationModal buttons viaconfirmButtonPropsandcancelButtonProps. Updates button types to useButtonPropsand excludes anchor types to ensure buttons render as buttons.🎟️ Jira ticket: LG-5794
✅ Checklist
pnpm changesetand documented my changes🧪 How to test changes
ConfirmationModalwithconfirmButtonProps={{ id: 'my-confirm-btn' }}andcancelButtonProps={{ id: 'my-cancel-btn' }}.idattributes in the DOM.PR Title:
[LG-5794] chore(confirmation-modal): add id prop support for buttons