PHPC-2478: Implement API for bulkWrite command #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
force-pushed
the
2.x-bulkwrite
branch
from
fe60b8b to
6e8c28a
Compare
jmikola
force-pushed
the
2.x-bulkwrite
branch
3 times, most recently
from
79e33fc to
786f1cc
Compare
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Mar 7, 2025
jmikola
force-pushed
the
2.x-bulkwrite
branch
2 times, most recently
from
ad72834 to
4a48529
Compare
It was possible to reuse WriteConcernError and WriteError with slight changes to their init functions.
This was not necessary for compilation, but it makes the header internally consistent.
Always return arrays for writeErrors and writeConcernErrors
Per CDRIVER-5843, libmongoc does not consistently populate this field. It also isn't required by the spec, so omit it for now.
Result maps should only be null if verboseResults=false. Additionally, the error reply document can default to an empty document on error (as it is in libmongoc).
Revise the stubs to reflect that executeBulkWriteCommand() always returns a BulkWriteCommandResult. If the result is unacknowledged, that is reported via isAcknowledged() and other methods can throw, which is consistent with WriteResult for the legacy bulk write API. If the result is empty on error (i.e. no writes were successful), BulkWriteCommandException::$partialResult is left unset.
This also ensures that BulkWriteCommandException uses the original server-side error code and message (if available) for top-level errors.
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Mar 14, 2025
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Mar 21, 2025
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Mar 21, 2025
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Mar 24, 2025
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Mar 31, 2025
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Apr 1, 2025
mongoc_bulkwriteexception_errorreply() always returns an initialized document, but it may be empty. This ensures that an InvalidArgumentException is not unnecessarily proxied behind a BulkWriteCommandException.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-2478
This supersedes #1763 and rebases the work on the v2.x branch.