Skip to content

Conversation

@GromNaN
Copy link
Member

@GromNaN GromNaN commented Dec 17, 2025

Fix PHPLIB-1750

The docker image mongodb/mongodb-atlas-local have a different behavior than MongoDB Atlas.

This change makes the test less sensible to the server output.

Fixed test:

Expected :'{ "mappings" : { "dynamic" : false } }'
Actual   :'{ "mappings" : { "dynamic" : false, "fields" : { } } }'

@GromNaN GromNaN requested a review from a team as a code owner December 17, 2025 17:10
@GromNaN GromNaN requested review from Copilot and jmikola December 17, 2025 17:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR relaxes the search index management spec test to accommodate behavioral differences between mongodb/mongodb-atlas-local and MongoDB Atlas. The docker image returns an additional empty fields property in the mapping response that causes test failures with strict document comparison.

Key Changes:

  • Replaced strict document equality assertions with targeted boolean checks on the dynamic property
  • Modified three test methods to verify only the dynamic field value instead of the entire mapping structure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant