Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PYTHON-5094 - Convert test.test_read_preferences to async #2110

Merged
merged 4 commits into from
Feb 5, 2025
Merged

PYTHON-5094 - Convert test.test_read_preferences to async #2110

merged 4 commits into from
Feb 5, 2025
+795 −50

Conversation

NoahStapp
Copy link
Contributor

No description provided.

@NoahStapp NoahStapp requested a review from sleepyStick January 31, 2025 16:41
sleepyStick
sleepyStick previously approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@sleepyStick sleepyStick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@NoahStapp NoahStapp requested a review from sleepyStick January 31, 2025 20:53
sleepyStick
sleepyStick previously approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@sleepyStick sleepyStick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@NoahStapp NoahStapp requested a review from sleepyStick February 3, 2025 20:13
@NoahStapp NoahStapp merged commit ac8fa2d into mongodb:master Feb 5, 2025
42 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleepyStick sleepyStick sleepyStick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoahStapp @sleepyStick