Skip to content

Cap proxy protocol TLV vector entry counts#1641

Open
parasol-aser wants to merge 1 commit intomongodb:masterfrom
parasol-aser:fix-proxy-protocol-tlv-cap
Open

Cap proxy protocol TLV vector entry counts#1641
parasol-aser wants to merge 1 commit intomongodb:masterfrom
parasol-aser:fix-proxy-protocol-tlv-cap

Conversation

@parasol-aser
Copy link
Copy Markdown

Summary

  • cap each proxy protocol TLV vector at 64 entries, including SSL sub-TLV vectors
  • reject overly dense TLV payloads before they can grow per-connection allocations on the proxy unix-socket path
  • add parser tests for the boundary, over-limit top-level TLVs, and over-limit SSL sub-TLVs

Testing

  • bazel test //src/mongo/transport:transport_test --test_arg=--gtest_filter=ProxyProtocolHeaderParser.*

@kelly-cs
Copy link
Copy Markdown
Contributor

Hi @parasol-aser!

Thanks for making this pull request! We just need a couple of things from you to start our consideration of the PR. Can you please:

  1. Sign our Contributor's Agreement.

  2. Create a new SERVER ticket on JIRA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants