Fix bracket-notation handling in no-printing-tojson rule#1642
Open
holly-agyei wants to merge 1 commit intomongodb:masterfrom
Open
Fix bracket-notation handling in no-printing-tojson rule#1642holly-agyei wants to merge 1 commit intomongodb:masterfrom
holly-agyei wants to merge 1 commit intomongodb:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the no-printing-tojson ESLint rule to correctly recognize jsTest logging helpers accessed via bracket notation (e.g., jsTest["log"].info(...) / jsTest.log["info"](...)) while avoiding AST mutation, and adds regression tests for both detection and autofix behavior.
Changes:
- Refactor callee-name normalization to be non-mutating and to support computed (bracket-notation) member expressions.
- Extend detection so bracket-notation access paths resolve to the same canonical names as dot notation.
- Add node:test-based regression tests covering bracket-notation detection and autofix output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| buildscripts/eslint-plugin-mongodb/rules/no-printing-tojson.js | Refactors callee flattening to handle bracket notation and avoid mutating the AST, enabling correct matching against known print/log targets. |
| buildscripts/eslint-plugin-mongodb/tests/no-printing-tojson.test.mjs | Adds regression tests validating bracket-notation detection and the autofix replacement to toJsonForLog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing