DOP-5290: fix links destinations #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for redoc-extension canceled.
|
✅ Deploy Preview for snooty-cache-extension canceled.
|
✅ Deploy Preview for populate-data-extension canceled.
|
✅ Deploy Preview for search-manifest-extension canceled.
|
✅ Deploy Preview for git-changed-file-extension canceled.
|
✅ Deploy Preview for persistence-module-ext canceled.
|
✅ Deploy Preview for redirects-and-publish-extension canceled.
|
seungpark
commented
Jan 22, 2025
| console.log('Skipping offline extension for env ', environment.env); | ||
| return; | ||
| } | ||
| // if (!ENVS_TO_RUN.includes(environment.ENV as string)) { |
There was a problem hiding this comment.
uncomment before merge. or can handle as part of DOP-5294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOP-5290
This PR aims to fix broken href links in the offline docs. Previous iteration was reading
node.hrefwhen scanning the DOM tree for anchor tags, which would include prefixes likefile://orabout://. This iteration usesgetAttributeto fetch the correct href/src value and replace it with a relative path.Successful deploy logs here
The uploaded offline doc can be found at this link: https://us-east-2.console.aws.amazon.com/s3/buckets/docs-mongodb-org-prd?region=us-east-2&bucketType=general&prefix=docs/offline/&showversions=false