-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(NODE-6626): implement integration tests for improved client.close() - server-side #4367
Conversation
34ccf67
to
804c464
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about unskipping tests that pass, and some optional comments. Otherwise LGTM
ddb638d
to
13a8a25
Compare
The base branch was changed.
8adfee6
to
08d8c26
Compare
7348d39
to
74673f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"the server-side ServerSession is cleaned up by client.close():"
test is failing, this one we can unskip but I think the issue is something with the namespace already/not existing?
@nbbeeken Error should be gone now but I'll wait for tests to pass on full CI before re-requesting review. I'm skipping the sessions tests on versions < 4.2 since that's what the $currentOp API requires to detect idleSessions |
013aee7
to
d522a1f
Compare
test/integration/node-specific/resource_tracking_script_builder.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one other comment
b25536d
to
4c1d06c
Compare
Description
Add server-side resource integration tests for client.close(). These tests will remain skipped until improved client.close() is implemented.
What is changing?
Is there new documentation needed for these changes?
No
What is the motivation for this change?
Improved client.close()
Release Highlight
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript