Skip to content

Conversation

@GalacticHypernova
Copy link

@GalacticHypernova GalacticHypernova commented Nov 7, 2025

Description

Summary of Changes

This updates the moduleResolution config property according to https://www.typescriptlang.org/tsconfig/#moduleResolution, as TS6 deprecated "node"

Note that I have not updated the tsd moduleResolutuion since I'm unsure whether it is following TS's footsteps on this matter. If it should also be updated, I will update it

Notes for Reviewers

What is the motivation for this change?

TS has deprecated the "node" moduleResolution, and now it sends errors in the console, hurting DX:

image

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@GalacticHypernova GalacticHypernova marked this pull request as ready for review November 7, 2025 13:59
@GalacticHypernova GalacticHypernova requested a review from a team as a code owner November 7, 2025 13:59
@GalacticHypernova
Copy link
Author

On a side note, I noticed mongodb isn't written in ESM, which can pose some issues in terms of tree-shaking and bundle sizes. If you find it appropriate, I can look into migrating the codebase to ESM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant