Skip to content

Conversation

oarbusi
Copy link
Collaborator

@oarbusi oarbusi commented Oct 1, 2025

Description

Fixes backport release issues.

  • Automatic commits to the release branch were done in master branch instead of master-v1
  • Revert those commits
  • Commits are now done in the master-v1 branch

Relevant files to review for the fix:

  • .github/templates/run-script-and-commit/action.yaml
  • .github/workflows/release-v1.yml

Also included changelog for 1.41.1 in CHANGELOG.md in 3ae62e6

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@oarbusi oarbusi marked this pull request as ready for review October 1, 2025 13:25
@oarbusi oarbusi requested review from a team as code owners October 1, 2025 13:25
@Copilot Copilot AI review requested due to automatic review settings October 1, 2025 13:25
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes backport release issues by ensuring automatic commits during the release process are made to the correct branch (master-v1) instead of the main branch (master). The changes address a release workflow problem and update version references in documentation.

  • Corrects branch targeting in the v1 release workflow to use master-v1 instead of master
  • Updates the reusable action template to accept a branch parameter for proper checkout
  • Reverts incorrect commits and updates version references from v1.41.1 to v2.0.1 in documentation

Reviewed Changes

Copilot reviewed 74 out of 74 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/release-v1.yml Adds branch parameter to ensure commits target master-v1 branch
.github/templates/run-script-and-commit/action.yaml Adds branch input parameter and checkout reference for flexible branch targeting
Multiple documentation files Updates version references from v1.41.1 to v2.0.1 in example links
CHANGELOG.md Removes v1.41.1 release entry
Compliance file Removes v1.41.1 compliance documentation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

github-actions bot commented Oct 1, 2025

APIx bot: a message has been sent to Docs Slack channel

@marcosuma
Copy link
Collaborator

Thank you @oarbusi - do we need to document and/or fix this process? can we also document the fact we have to manually set to latest when we do this type of emergency release?

@oarbusi
Copy link
Collaborator Author

oarbusi commented Oct 1, 2025

@marcosuma I have created CLOUDP-348811 to handle the documentation of the backport process and manual steps that need to be taken. This PR should now fix the automatic commits so that they are pushed to master-v1 instead of master. No need for any further fix


* resource/mongodbatlas_advanced_cluster: Allows upgrade from tenant and flex cluster to dedicated NVMe with backup enabled ([#3725](https://github.com/mongodb/terraform-provider-mongodbatlas/pull/3725))

## 1.41.1 (October 01, 2025)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shoud we have the changelog in publication date or release version order? I think it would be better to have 1.41.1 before 2.0.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will discuss offline

@oarbusi oarbusi merged commit 02eea6d into master Oct 2, 2025
44 checks passed
@oarbusi oarbusi deleted the backport-release-fixes branch October 2, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants