-
Notifications
You must be signed in to change notification settings - Fork 208
chore: Fixes backport release issues #3734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes backport release issues by ensuring automatic commits during the release process are made to the correct branch (master-v1
) instead of the main branch (master
). The changes address a release workflow problem and update version references in documentation.
- Corrects branch targeting in the v1 release workflow to use
master-v1
instead ofmaster
- Updates the reusable action template to accept a branch parameter for proper checkout
- Reverts incorrect commits and updates version references from v1.41.1 to v2.0.1 in documentation
Reviewed Changes
Copilot reviewed 74 out of 74 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
.github/workflows/release-v1.yml |
Adds branch parameter to ensure commits target master-v1 branch |
.github/templates/run-script-and-commit/action.yaml |
Adds branch input parameter and checkout reference for flexible branch targeting |
Multiple documentation files | Updates version references from v1.41.1 to v2.0.1 in example links |
CHANGELOG.md |
Removes v1.41.1 release entry |
Compliance file | Removes v1.41.1 compliance documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
APIx bot: a message has been sent to Docs Slack channel |
Thank you @oarbusi - do we need to document and/or fix this process? can we also document the fact we have to manually set to latest when we do this type of emergency release? |
@marcosuma I have created CLOUDP-348811 to handle the documentation of the backport process and manual steps that need to be taken. This PR should now fix the automatic commits so that they are pushed to master-v1 instead of master. No need for any further fix |
|
||
* resource/mongodbatlas_advanced_cluster: Allows upgrade from tenant and flex cluster to dedicated NVMe with backup enabled ([#3725](https://github.com/mongodb/terraform-provider-mongodbatlas/pull/3725)) | ||
|
||
## 1.41.1 (October 01, 2025) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shoud we have the changelog in publication date or release version order? I think it would be better to have 1.41.1 before 2.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will discuss offline
Description
Fixes backport release issues.
master
branch instead ofmaster-v1
master-v1
branchRelevant files to review for the fix:
.github/templates/run-script-and-commit/action.yaml
.github/workflows/release-v1.yml
Also included changelog for 1.41.1 in CHANGELOG.md in 3ae62e6
Link to any related issue(s):
Type of change:
Required Checklist:
Further comments