feat: Adds port_mapping_enabled attribute to privatelink_endpoint and privatelink_endpoint_service #4017

filipcirtog · 2025-12-22T12:00:05Z

Description

This PR implements support for the new architecture of GCP Private Service Connect (PSC). For this, we add a new attribute named port_mapping_enabled to both mongodbatlas_privatelink_endpoint and mongodbatlas_privatelink_endpoint_service resources and data sources.

Changes

Added port_mapping_enabled field to:
- mongodbatlas_privatelink_endpoint resource (optional, ForceNew)
- mongodbatlas_privatelink_endpoint data source (computed)
- mongodbatlas_privatelink_endpoint_service resource (computed)
- mongodbatlas_privatelink_endpoint_service data source (computed)
Updated documentation for all affected resources and data sources
Added test coverage:
- Test case for explicitly enabled port mapping
- Test case for explicitly disabled port mapping

Link to any related issue(s): CLOUDP-363082

Type of change:

Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
This change requires a documentation update
Documentation fix/enhancement

Required Checklist:

I have signed the MongoDB CLA
I have read the contributing guides
I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
I have added any necessary documentation (if appropriate)
I have run make fmt and formatted my code
If changes include deprecations or removals I have added appropriate changelog entries.
If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

…p-port-based-routing-implementation

github-actions · 2025-12-22T15:19:49Z

APIx bot: a message has been sent to Docs Slack channel

Copilot

Pull request overview

This PR adds support for GCP Private Service Connect (PSC) port-mapping architecture by introducing a port_mapping_enabled attribute to privatelink endpoint resources and data sources. The attribute allows users to explicitly control whether PSC port-mapping is enabled when creating GCP private endpoints.

Key Changes:

Added port_mapping_enabled boolean attribute to privatelink_endpoint (optional, ForceNew) and privatelink_endpoint_service (computed)
Implemented test coverage for both explicitly enabled and disabled port mapping scenarios
Updated documentation for all affected resources and data sources

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
internal/service/privatelinkendpoint/resource.go	Added optional `port_mapping_enabled` field to resource schema and create/read logic
internal/service/privatelinkendpoint/data_source.go	Added computed `port_mapping_enabled` field to data source schema and read logic
internal/service/privatelinkendpointservice/resource.go	Added computed `port_mapping_enabled` field to resource schema and read logic for GCP
internal/service/privatelinkendpointservice/data_source.go	Added computed `port_mapping_enabled` field to data source schema and read logic for GCP
internal/service/privatelinkendpoint/resource_test.go	Added test coverage for port mapping enabled/disabled scenarios and updated existing test assertions
docs/resources/privatelink_endpoint.md	Documented the new `port_mapping_enabled` attribute
docs/resources/privatelink_endpoint_service.md	Documented the new `port_mapping_enabled` attribute
docs/data-sources/privatelink_endpoint.md	Documented the new `port_mapping_enabled` attribute
docs/data-sources/privatelink_endpoint_service.md	Documented the new `port_mapping_enabled` attribute
.changelog/4017.txt	Added changelog entries for the enhancement

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-22T15:20:06Z

internal/service/privatelinkendpoint/resource_test.go

+	var (
+		resourceName       = "mongodbatlas_privatelink_endpoint.test"
+		orgID              = os.Getenv("MONGODB_ATLAS_ORG_ID")
+		projectName        = "test-acc-tf-p-gcp-port-based-routing-feature-flag-enabled"


The project name references 'feature-flag-enabled' but this test is for explicitly enabled port mapping, not feature flag testing. Consider renaming to something like 'test-acc-tf-p-gcp-port-mapping-enabled' for clarity.

Suggested change

projectName = "test-acc-tf-p-gcp-port-based-routing-feature-flag-enabled"

projectName = "test-acc-tf-p-gcp-port-mapping-enabled"

Note: This will be updated to use the random name once the feature is officially released (GA) and not gated by a feature-flag (before merging to master)

internal/service/privatelinkendpoint/resource_test.go

lizo-mdb

LGTM

EspenAlbert · 2025-12-22T15:34:23Z

docs/resources/privatelink_endpoint.md

 Accepted values are: [AWS regions](https://docs.atlas.mongodb.com/reference/amazon-aws/#amazon-aws), [AZURE regions](https://docs.atlas.mongodb.com/reference/microsoft-azure/#microsoft-azure) and [GCP regions](https://docs.atlas.mongodb.com/reference/google-gcp/#std-label-google-gcp)
 * `timeouts`- (Optional) The duration of time to wait for Private Endpoint to be created or deleted. The timeout value is defined by a signed sequence of decimal numbers with a time unit suffix such as: `1h45m`, `300s`, `10m`, etc. The valid time units are:  `ns`, `us` (or `µs`), `ms`, `s`, `m`, `h`. The default timeout for Private Endpoint create & delete is `1h`. Learn more about timeouts [here](https://www.terraform.io/plugin/sdkv2/resources/retries-and-customizable-timeouts).
 * `delete_on_create_timeout`- (Optional) Indicates whether to delete the resource being created if a timeout is reached when waiting for completion. When set to `true` and timeout occurs, it triggers the deletion and returns immediately without waiting for deletion to complete. When set to `false`, the timeout will not trigger resource deletion. If you suspect a transient error when the value is `true`, wait before retrying to allow resource deletion to finish. Default is `true`.
+* `port_mapping_enabled` - (Optional) Flag that indicates whether this endpoint service uses PSC port-mapping.


[nit] Is there any example we can update also? I struggle a bit to understand this feature seeing only this variable description

This is the description available on Atlas and unfortunately we are not able to update it. (we need DELETE + CREATE)

I just wanted to know if we have an example in repo_root/examples/* .tf that we could update?

This makes total sense. I will add an example for this.

EspenAlbert · 2025-12-22T15:35:38Z

internal/service/privatelinkendpoint/resource_test.go

+				),
+			},
+			{
+				ResourceName:      resourceName,


nice to add the import step 👍

it's just git displaying the diff wrong as that was already there but it just got pushed back to the end :)

EspenAlbert · 2025-12-22T15:37:10Z

internal/service/privatelinkendpoint/resource_test.go

+					resource.TestCheckResourceAttrSet(resourceName, "region"),
+					resource.TestCheckResourceAttr(resourceName, "provider_name", providerName),
+					resource.TestCheckResourceAttr(resourceName, "region", region),
+					resource.TestCheckResourceAttr(resourceName, "port_mapping_enabled", "true"),


[nit] not sure if it is worth testing the attribute changes:
null -> true
true -> false

Also, does this value have a default? (What is returned by the API if the field is not set?)
What is the difference between false and null? Will null -> false and ForceNew leading to an unnecessary DELETE+CREATE plan?

Attribute changes (null -> true, true -> false):
These transitions were not tested since I thought it is not needed because of ForceNew. I will add those.

Default value:
Atlas defaults this attribute to false. Should we do the same?

null vs false:
I will check this as I do not have a response now (I personally expect yes).

oarbusi

LGTM

github-actions · 2025-12-29T00:35:51Z

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

filipcirtog added 7 commits December 4, 2025 12:15

replace prod SDK with preview SDK for private endpoint/endpoint service

332be39

nit: add missing comments

9175dce

gcp port routing implementation

8a9562f

remove default values

ca4cacf

doc: update resource and data-source attributes

ed3e818

add test case for disabled new architecture

d6725b9

q: consistency updates

7545b99

filipcirtog changed the title ~~Cloudp 363082 gcp port based routing implementation~~ feat: Add port_mapping_enabled attribute to privateEndpoint and privateEndpointService Dec 22, 2025

github-actions bot added the enhancement label Dec 22, 2025

Merge branch 'CLOUDP-346617-dev-gcp-port-based' into CLOUDP-363082-gc…

3752b5a

…p-port-based-routing-implementation

filipcirtog changed the title ~~feat: Add port_mapping_enabled attribute to privateEndpoint and privateEndpointService~~ feat: Add port_mapping_enabled attribute to privatelink_endpoint and privatelink_endpoint_service Dec 22, 2025

filipcirtog changed the title ~~feat: Add port_mapping_enabled attribute to privatelink_endpoint and privatelink_endpoint_service~~ feat: Adds port_mapping_enabled attribute to privatelink_endpoint and privatelink_endpoint_service Dec 22, 2025

filipcirtog added 3 commits December 22, 2025 14:14

changelog

cfb1e0f

q: consistency

3a32c9f

q: consistency

df750a7

filipcirtog marked this pull request as ready for review December 22, 2025 15:19

filipcirtog requested review from a team as code owners December 22, 2025 15:19

Copilot AI review requested due to automatic review settings December 22, 2025 15:19

Copilot AI reviewed Dec 22, 2025

View reviewed changes

lizo-mdb approved these changes Dec 22, 2025

View reviewed changes

EspenAlbert reviewed Dec 22, 2025

View reviewed changes

oarbusi approved these changes Dec 23, 2025

View reviewed changes

github-actions bot added the stale label Dec 29, 2025

github-actions bot closed this Jan 1, 2026

filipcirtog added the not_stale Not stale issue or PR label Jan 8, 2026

filipcirtog removed the stale label Jan 8, 2026

filipcirtog reopened this Jan 8, 2026

add more test cases

be386c1

	projectName = "test-acc-tf-p-gcp-port-based-routing-feature-flag-enabled"
	projectName = "test-acc-tf-p-gcp-port-mapping-enabled"

feat: Adds port_mapping_enabled attribute to privatelink_endpoint and privatelink_endpoint_service #4017

Are you sure you want to change the base?

feat: Adds port_mapping_enabled attribute to privatelink_endpoint and privatelink_endpoint_service #4017

Uh oh!

Conversation

filipcirtog commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Type of change:

Required Checklist:

Further comments

Uh oh!

github-actions bot commented Dec 22, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

filipcirtog Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lizo-mdb left a comment

Choose a reason for hiding this comment

Uh oh!

EspenAlbert Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

filipcirtog Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

EspenAlbert Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

filipcirtog Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

EspenAlbert Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

filipcirtog Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

EspenAlbert Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

filipcirtog Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

oarbusi left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

filipcirtog commented Dec 22, 2025 •

edited

Loading

EspenAlbert Dec 23, 2025 •

edited

Loading

EspenAlbert Dec 22, 2025 •

edited

Loading