Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return false instead of nil for reference types, when value is false-y #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mzikherman
Copy link

@mzikherman mzikherman commented Apr 18, 2023

Noticing an odd bug where if a field has type: :reference and the definition is something that returns false, the value of nil gets returned instead of the correct false.

👋 @dblock

@dblock
Copy link
Collaborator

dblock commented Apr 19, 2023

Hello there! I think we need to do #27 before we start merging other changes. Maybe add Mongoid 8 support? Care to do that?

@mzikherman
Copy link
Author

Yup, I can do that. I was noticing the lack of CI yesterday, I ran the spec suite locally but just with the specific version of Ruby/Mongoid I happened to be using and was curious to see the matrix run w/ multiple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants