Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash when closing the app when running #269

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Fix a crash when closing the app when running #269

merged 3 commits into from
Apr 8, 2024

Conversation

mattleibow
Copy link
Contributor

Description of Change

After #267, the views are no longer leaking. This is good, but now the views are potentially collected and the timer will still try invalidating.

Not sure how it never came up in testing, but this PR will now also make sure the view is valid and loaded befoer drawing.

@mattleibow mattleibow merged commit 62f66e6 into main Apr 8, 2024
3 checks passed
@mattleibow mattleibow deleted the dev/crash branch April 8, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant