Proper logging: before the exception body was lost, now it's logged.

mono · Dec 20, 2016 · 0657baa · 0657baa
1 parent 8eba0ab
commit 0657baa
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/Mono.Debugging/Mono.Debugging.Client/ObjectValue.cs b/Mono.Debugging/Mono.Debugging.Client/ObjectValue.cs
@@ -541,8 +541,7 @@ public ObjectValue[] GetAllChildren (EvaluationOptions options)
 						ConnectCallbacks (parentFrame, cs);
 						children.AddRange (cs);
 					} catch (Exception ex) {
-						if (parentFrame != null)
-							parentFrame.DebuggerSession.OnDebuggerOutput (true, ex.ToString ());
+						DebuggerLoggingService.LogError ("Exception in GetAllChildren()", ex);
 						children.Add (CreateFatalError ("", ex.Message, ObjectValueFlags.ReadOnly));
 					}
 				}

diff --git a/Mono.Debugging/Mono.Debugging.Evaluation/ObjectValueAdaptor.cs b/Mono.Debugging/Mono.Debugging.Evaluation/ObjectValueAdaptor.cs
@@ -590,7 +590,7 @@ public virtual ObjectValue[] GetObjectValueChildren (EvaluationContext ctx, IObj
 						values.Add (oval);
 					}
 				} catch (Exception ex) {
-					ctx.WriteDebuggerError (ex);
+					DebuggerLoggingService.LogError ("Exception in GetObjectValueChildren()", ex);
 					values.Add (ObjectValue.CreateError (null, new ObjectPath (val.Name), GetDisplayTypeName (GetTypeName (ctx, val.Type)), ex.Message, val.Flags));
 				}
 			}

diff --git a/Mono.Debugging/Mono.Debugging.Evaluation/ValueReference.cs b/Mono.Debugging/Mono.Debugging.Evaluation/ValueReference.cs
@@ -110,8 +110,9 @@ public ObjectValue CreateObjectValue (EvaluationOptions options)
 				return DC.ObjectValue.CreateEvaluationException (Context, Context.ExpressionValueSource, new ObjectPath (Name), ex);
 			} catch (EvaluatorException ex) {
 				return DC.ObjectValue.CreateError (this, new ObjectPath (Name), "", ex.Message, Flags);
-			} catch (Exception ex) {
-				Context.WriteDebuggerError (ex);
+			}
+			catch (Exception ex) {
+				DebuggerLoggingService.LogError ("Exception in CreateObjectValue()", ex);
 				return DC.ObjectValue.CreateUnknown (Name);
 			}
 		}