Ignore exceptions trying to read IPTC-IIM data #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having TagLibSharp just throw an exception when it can't read an IPTC-IIM segment is causing problems for some of our users.
This is the least important of the metadata segments, generally speaking, and the TagLibSharp code only pulls a handful of values
from it in any case. Our bug report at https://issues.bloomlibrary.org/youtrack/issue/BL-11933 has a jpeg image that shows
the problem. I can get around not being able to use the image at all by catching the exception in one of our libraries that
uses TagLibSharp, but it prevents other metadata from the file from being available, which causes some problems with suboptimal handling of the image file.